Re: [PATCH] cpuset semaphore depth check optimize

Paul Jackson
2005-09-20T15:14:41Z

Robin wrote:
> This makes things even easier!!!

Easy is good.

> When the vfs code is traversing the list, you need to ensure
> that it does not iterate unless the child list lock is held.
> I have not looked at how you implemented the vfs stuff, but
> that should be easily accomplished.
>
> Where are the holes?

The hole is my understanding of vfs.

My gut instinct is to recoil in horror from this suggestion, because it
seems to involve walking the cpuset tree from bottom up, setting locks,
while some other task might be doing a normal file system open on one
of these cpusets, walking the tree top-down, setting locks.

That smells like deadlock city to me.

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401