From: Ben Dooks <ben-linux@fluff.org>
To: Keith Owens <kaos@ocs.com.au>
Cc: Ben Dooks <ben-linux@fluff.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts - use $OBJDUMP to get correct objdump (cross compile)
Date: Tue, 20 Sep 2005 15:39:58 +0100 [thread overview]
Message-ID: <20050920143958.GA3500@home.fluff.org> (raw)
In-Reply-To: <12002.1127204929@kao2.melbourne.sgi.com>
On Tue, Sep 20, 2005 at 06:28:49PM +1000, Keith Owens wrote:
> On Mon, 19 Sep 2005 22:06:45 +0100,
> Ben Dooks <ben-linux@fluff.org> wrote:
> >The scripts for `make buildcheck` are executing
> >objdump straight, which is wrong if the system
> >is using `make CROSS_COMPILE=....`.
> >
> >Change the scripts to use $OBJDUMP passed from
> >the Makefile's environment, so that the correct
> >objdump is used, and the symbols are printed
> >correctly
>
> Those scripts are meant to work even when they are invoked by hand,
> without OBJDUMP being defined in the environment. This is the correct
> fix.
>
> Signed-off-by: Keith Owens <kaos@ocs.com.au>
Ok, that seems to have fixed the problems, thanks.
Acked-by: Ben Dooks <ben-linux@fluff.org>
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next prev parent reply other threads:[~2005-09-20 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-19 21:06 [PATCH] scripts - use $OBJDUMP to get correct objdump (cross compile) Ben Dooks
2005-09-20 8:28 ` Keith Owens
2005-09-20 14:39 ` Ben Dooks [this message]
[not found] <4OB3R-5gu-13@gated-at.bofh.it>
[not found] ` <4OLPC-3NQ-19@gated-at.bofh.it>
2005-09-20 16:55 ` Bodo Eggert
2005-09-20 18:43 ` Valdis.Kletnieks
2005-09-20 19:03 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050920143958.GA3500@home.fluff.org \
--to=ben-linux@fluff.org \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox