From: Al Viro <viro@ftp.linux.org.uk>
To: "Paolo 'Blaisorblade' Giarrusso" <blaisorblade@yahoo.it>
Cc: Antoine Martin <antoine@nagafix.co.uk>,
Al Viro <viro@zeniv.linux.org.uk>, Jeff Dike <jdike@addtoit.com>,
user-mode-linux-devel@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 04/12] HPPFS: fix access to ppos and file->f_pos
Date: Wed, 21 Sep 2005 04:46:49 +0100 [thread overview]
Message-ID: <20050921034649.GX7992@ftp.linux.org.uk> (raw)
In-Reply-To: <20050918140951.31461.78736.stgit@zion.home.lan>
On Sun, Sep 18, 2005 at 04:09:51PM +0200, Paolo 'Blaisorblade' Giarrusso wrote:
> static ssize_t read_proc(struct file *file, char *buf, ssize_t count,
> loff_t *ppos, int is_user)
> {
> @@ -228,17 +237,21 @@ static ssize_t read_proc(struct file *fi
> if (read == NULL)
> return -EINVAL;
>
> + WARN_ON(is_user != (ppos != NULL));
Eww.... Why not pass the right ppos in all cases?
next prev parent reply other threads:[~2005-09-21 3:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-18 14:09 [PATCH 04/12] HPPFS: fix access to ppos and file->f_pos Paolo 'Blaisorblade' Giarrusso
2005-09-21 3:46 ` Al Viro [this message]
2005-09-21 16:48 ` Blaisorblade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050921034649.GX7992@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=antoine@nagafix.co.uk \
--cc=blaisorblade@yahoo.it \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox