public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86-64: Fix bad assumption that dualcore cpus have synced TSCs
@ 2005-09-19 19:16 john stultz
  2005-09-19 19:31 ` Andi Kleen
  2005-10-07 12:26 ` Vladimir B. Savkin
  0 siblings, 2 replies; 28+ messages in thread
From: john stultz @ 2005-09-19 19:16 UTC (permalink / raw)
  To: Andrew Morton; +Cc: lkml, Andi Kleen

Andrew,
	This patch should resolve the issue seen in bugme bug #5105, where it
is assumed that dualcore x86_64 systems have synced TSCs. This is not
the case, and alternate timesources should be used instead.

For more details, see:
http://bugzilla.kernel.org/show_bug.cgi?id=5105


Please consider for inclusion in your tree.

thanks
-john

diff --git a/arch/x86_64/kernel/time.c b/arch/x86_64/kernel/time.c
--- a/arch/x86_64/kernel/time.c
+++ b/arch/x86_64/kernel/time.c
@@ -959,9 +959,6 @@ static __init int unsynchronized_tsc(voi
  	   are handled in the OEM check above. */
  	if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL)
  		return 0;
- 	/* All in a single socket - should be synchronized */
- 	if (cpus_weight(cpu_core_map[0]) == num_online_cpus())
- 		return 0;
 #endif
  	/* Assume multi socket systems are not synchronized */
  	return num_online_cpus() > 1;



^ permalink raw reply	[flat|nested] 28+ messages in thread
* RE: [discuss] Re: [PATCH] x86-64: Fix bad assumption that dualcore cpus have synced TSCs
@ 2005-09-20 19:13 Langsdorf, Mark
  2005-09-20 19:24 ` Scott Lampert
  0 siblings, 1 reply; 28+ messages in thread
From: Langsdorf, Mark @ 2005-09-20 19:13 UTC (permalink / raw)
  To: john stultz, Andi Kleen; +Cc: Andrew Morton, lkml, discuss

> On Mon, 2005-09-19 at 21:49 +0200, Andi Kleen wrote:
> > On Mon, Sep 19, 2005 at 12:42:16PM -0700, john stultz wrote:
> > > On Mon, 2005-09-19 at 21:31 +0200, Andi Kleen wrote:
> > > > On Mon, Sep 19, 2005 at 12:16:43PM -0700, john stultz wrote:
> > > > > 	This patch should resolve the issue seen in 
> bugme bug #5105, 
> > > > > where it is assumed that dualcore x86_64 systems have synced 
> > > > > TSCs. This is not the case, and alternate timesources 
> should be 
> > > > > used instead.
> > > > 
> > > > 
> > > > I asked AMD some time ago and they told me it was synchronized. 
> > > > The TSC on K8 is C state invariant, but not P state 
> invariant, but 
> > > > P states always happen synchronized on dual cores.
> > > > 
> > > > So I'm not quite convinced of your explanation yet.
> > > 
> > > Would a litter userspace test checking the TSC 
> synchronization maybe 
> > > shed additional light on the issue?
> > 
> > Sure you can try it.
> 
> So, bugzilla.kernel.org has (temporarily at least) lost the 
> reports from yesterday, but from the email i got, folks using 
> my TSC consistency check that I posted were seeing what 
> appears to be unsynched TSCs on dualcore AMD systems.

My understanding was that each TSC on a dual-core processor
will advance individually and atomically.  They will not 
always be in synchronization.

> Personally I suspect that the powernow driver is putting the 
> cores independently into low power sleep and the TSCs are 
> being independently halted, causing them to become unsynchronized.

The powernow-k8 driver doesn't know what a low power sleep state
is, so I strongly doubt it is involved here.  It only handles
pstates.
 
-Mark Langsdorf
K8 PowerNow! Maintainer
AMD, Inc.


^ permalink raw reply	[flat|nested] 28+ messages in thread

end of thread, other threads:[~2005-10-26  0:06 UTC | newest]

Thread overview: 28+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-19 19:16 [PATCH] x86-64: Fix bad assumption that dualcore cpus have synced TSCs john stultz
2005-09-19 19:31 ` Andi Kleen
2005-09-19 19:42   ` john stultz
2005-09-19 19:49     ` [discuss] " Andi Kleen
2005-09-20 18:59       ` john stultz
2005-09-21  4:03         ` Daniel Jacobowitz
2005-09-21 15:15           ` Ray Bryant
2005-09-21 15:04             ` Andi Kleen
2005-09-21 15:46               ` Ray Bryant
2005-09-22  8:00                 ` Jonas Oreland
2005-09-21 20:17               ` Andrew Morton
2005-10-07 12:26 ` Vladimir B. Savkin
2005-10-07 12:31   ` Andi Kleen
2005-10-07 14:15     ` Vladimir B. Savkin
2005-10-07 14:21       ` [discuss] " Velu Erwan
2005-10-08 10:11     ` Vladimir B. Savkin
2005-10-10 18:03       ` john stultz
2005-10-10 18:12         ` Vladimir B. Savkin
2005-10-10 18:19           ` Jonas Oreland
2005-10-11  7:35             ` Vladimir B. Savkin
2005-10-11  8:06               ` Andi Kleen
2005-10-11 16:27               ` Jonas Oreland
2005-10-25  7:35                 ` x86-64: Syncing dualcore cpus TSCs Jonas Oreland
2005-10-25  7:42                   ` Andi Kleen
2005-10-26  0:05                     ` David Lang
  -- strict thread matches above, loose matches on Subject: below --
2005-09-20 19:13 [discuss] Re: [PATCH] x86-64: Fix bad assumption that dualcore cpus have synced TSCs Langsdorf, Mark
2005-09-20 19:24 ` Scott Lampert
2005-09-20 19:30   ` john stultz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox