OOPS in 2.6.13: jfsCommit

OOPS in 2.6.13: jfsCommit

[SR, ESC]

[-- Attachment #1.1: Type: text/plain, Size: 1593 bytes --]


hi,

i encountered an OOPS during boot here. dropped the machine into xmon
even. during boot, i got what's in the attached file
(kernel_bug_2.6.13_jfsCommit).

the machine is:

cat /proc/cpuinfo
processor       : 0
cpu             : 740/750
temperature     : 33-37 C (uncalibrated)
clock           : 195MHz
revision        : 2.2 (pvr 0008 0202)
bogomips        : 602.11
machine         : Power Macintosh
motherboard     : AAPL,9500 MacRISC
detected as     : 16 (PowerMac 9500/9600)
pmac flags      : 00000000
memory          : 512MB
pmac-generation : OldWorld


0000:00:0b.0 Host bridge: Apple Computer Inc. Bandit PowerPC host bridge (rev 03)
0000:00:0e.0 PCI bridge: Digital Equipment Corporation DECchip 21152 (rev 03)
0000:00:0f.0 VGA compatible controller: ATI Technologies Inc 3D Rage LT Pro (rev dc)
0000:00:10.0 ff00: Apple Computer Inc. Grand Central I/O (rev 02)
0000:01:00.0 Memory controller: Adaptec AIC-7815 RAID+Memory Controller IC (rev 02)
0000:01:04.0 SCSI storage controller: Adaptec 78902
0001:02:0b.0 Host bridge: Apple Computer Inc. Bandit PowerPC host bridge (rev 03)
0001:02:0e.0 Ethernet controller: Lite-On Communications Inc LNE100TX (rev 20)


PLEASE CC: ME, thanks.

-- 
 http://www.nuit.ca/ http://home.earthlink.net/~wodensharrow/hah.html   ,''`.   http://www.debian.org/
 http://simonraven.nuit.ca/ http://www.antiracistaction.ca/             : :' :  Debian GNU/Linux
 http://pentangle.nuit.ca/ezine/vol_x/x0305.html                        '
                                                                          `-

[-- Attachment #1.2: kernel_bug_2.6.13_jfsCommit --]
[-- Type: text/plain, Size: 877 bytes --]

kernel BUG in generic_delete_inode at fs/inode.c:1055!
Oops: Exception in kernel mode, sig: 5 [#1]
NIP: C008A6C4 LR: C008A6B8 SP: DFFD3F20 REGS: dffd3e70 TRAP: 0700    Not tainted
MSR: 00029032 EE: 1 PR: 0 FP: 0 ME: 1 IR/DR: 11
TASK = c0bbe070[60] 'jfsCommit' THREAD: dffd2000
Last syscall: -1 
GPR00: 00000010 DFFD3F20 C0BBE070 C0517438 00000003 00000001 DFFD3EF8 DF5DA200 
GPR08: C0700000 C0517000 9E370001 C03FF43C 39AD3E35 DEADBEEF 003F0000 DEADBEEF 
GPR16: 00000000 DEADBEEF DEADBEEF 007A94B8 007A94B8 C03B0000 C03B0000 C04D0000 
GPR24: 00000010 00000000 00000001 DEA41C88 E1000EC4 CA12B360 C00FC520 CA12B360 
NIP [c008a6c4] generic_delete_inode+0x114/0x1b0
LR [c008a6b8] generic_delete_inode+0x108/0x1b0
Call trace:
 [c0089998] iput+0x98/0xc0
 [c011ffc4] txUpdateMap+0x254/0x320
 [c01205b8] jfs_lazycommit+0x178/0x280
 [c0007224] kernel_thread+0x44/0x60

[-- Attachment #2: Type: application/pgp-signature, Size: 652 bytes --]

Re: OOPS in 2.6.13: jfsCommit

[Dave Kleikamp]

On Tue, 2005-08-30 at 07:59 -0400, SR, ESC wrote:
> hi,
> 
> i encountered an OOPS during boot here. dropped the machine into xmon
> even. during boot, i got what's in the attached file
> (kernel_bug_2.6.13_jfsCommit).

I think the problem may be a recent change to jfs_delete_inode.  Does
this patch fix the problem?
---------------------------------------------------------------------
JFS: jfs_delete_inode should always call clear_inode.

Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.com>

diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c
--- a/fs/jfs/inode.c
+++ b/fs/jfs/inode.c
@@ -128,21 +128,21 @@ void jfs_delete_inode(struct inode *inod
 {
 	jfs_info("In jfs_delete_inode, inode = 0x%p", inode);
 
-	if (is_bad_inode(inode) ||
-	    (JFS_IP(inode)->fileset != cpu_to_le32(FILESYSTEM_I)))
-			return;
+	if (!is_bad_inode(inode) &&
+	    (JFS_IP(inode)->fileset == cpu_to_le32(FILESYSTEM_I))) {
 
-	if (test_cflag(COMMIT_Freewmap, inode))
-		jfs_free_zero_link(inode);
+		if (test_cflag(COMMIT_Freewmap, inode))
+			jfs_free_zero_link(inode);
 
-	diFree(inode);
+		diFree(inode);
 
-	/*
-	 * Free the inode from the quota allocation.
-	 */
-	DQUOT_INIT(inode);
-	DQUOT_FREE_INODE(inode);
-	DQUOT_DROP(inode);
+		/*
+		 * Free the inode from the quota allocation.
+		 */
+		DQUOT_INIT(inode);
+		DQUOT_FREE_INODE(inode);
+		DQUOT_DROP(inode);
+	}
 
 	clear_inode(inode);
 }

-- 
David Kleikamp
IBM Linux Technology Center

Re: OOPS in 2.6.13: jfsCommit

[SR, ESC]

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

Le mar 2005-08-30 a 12:48:17 -0400, Dave Kleikamp <shaggy@austin.ibm.com> a dit:
> On Tue, 2005-08-30 at 07:59 -0400, SR, ESC wrote:
> 
> I think the problem may be a recent change to jfs_delete_inode.  Does
> this patch fix the problem?

thanks, i'll give a try. 

simon

> -- 
> David Kleikamp
> IBM Linux Technology Center
> 

-- 
Microsoft is to operating systems & security ....
                                 .... what McDonalds is to gourmet cooking.
                -- unknown; seen in Marc Merlin's .sig

[-- Attachment #2: Type: application/pgp-signature, Size: 652 bytes --]

Re: OOPS in 2.6.13: jfsCommit

[SR, ESC]

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

Le mar 2005-08-30 a 12:48:17 -0400, Dave Kleikamp <shaggy@austin.ibm.com> a dit:
> On Tue, 2005-08-30 at 07:59 -0400, SR, ESC wrote:
> > hi,
> > 
> > i encountered an OOPS during boot here. dropped the machine into xmon
> > even. during boot, i got what's in the attached file
> > (kernel_bug_2.6.13_jfsCommit).
> 
> I think the problem may be a recent change to jfs_delete_inode.  Does
> this patch fix the problem?

so far so good. box seems "happy". no Oopses. thank you very much :).

simon

-- 
make zImage, not war.

[-- Attachment #2: Type: application/pgp-signature, Size: 652 bytes --]