From: Andrew Morton <akpm@osdl.org>
To: Max Kellermann <max@duempel.org>
Cc: linux-kernel@vger.kernel.org, avuton@gmail.com,
Trond Myklebust <trond.myklebust@fys.uio.no>
Subject: Re: [PATCH] repair nfsd/sunrpc in 2.6.14-rc2-mm1 (and other -mm versions)
Date: Thu, 22 Sep 2005 12:27:49 -0700 [thread overview]
Message-ID: <20050922122749.555e0068.akpm@osdl.org> (raw)
In-Reply-To: <20050922130441.GA24005@roonstrasse.net>
Max Kellermann <max@duempel.org> wrote:
>
> nfsd is still broken in 2.6.14-rc2-mm1; the following procedure is
> reproducable:
>
> rabbit:~# echo 2 >/proc/fs/nfsd/threads
>
> ... /var/log/daemon.log says:
>
> Sep 22 13:52:55 rabbit kernel: NFSD: Using /var/lib/nfs/v4recovery as
> the NFSv4 state recovery directory
> Sep 22 13:52:55 rabbit kernel: NFSD: starting 90-second grace period
> Sep 22 13:52:55 rabbit portmap[3191]: connect from 127.0.0.1 to
> set(nfs): request from unprivileged port
>
> Your -mm patches make the sunrpc client connect to the portmapper with
> a non-privileged source port. This is due to a change in
> net/sunrpc/pmap_clnt.c, which manually resets the xprt->resvport
> field. My tiny patch removes this line. I have no idea why the line
> was added in the first place, does somebody know better?
>
That change comes from Trond's git tree. I don't know why the change was
made.
Trond, rsync://client.linux-nfs.org/pub/linux/nfs-2.6.git hasn't been
updated in quite some time, I think. I still need to revert the oopsy
rpc_mkdir() change. Am I using the right tree?
>
> [nfsd-pmap-fix-privileged-port.patch text/plain (522 bytes)]
> --- linux-2.6.14-rc2-mm1/net/sunrpc/pmap_clnt.c.orig 2005-09-22 14:58:14.000000000 +0200
> +++ linux-2.6.14-rc2-mm1/net/sunrpc/pmap_clnt.c 2005-09-22 14:58:16.000000000 +0200
> @@ -208,7 +208,6 @@
> if (IS_ERR(xprt))
> return (struct rpc_clnt *)xprt;
> xprt->addr.sin_port = htons(RPC_PMAP_PORT);
> - xprt->resvport = 0;
>
> /* printk("pmap: create clnt\n"); */
> clnt = rpc_new_client(xprt, hostname,
next prev parent reply other threads:[~2005-09-22 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-22 13:04 [PATCH] repair nfsd/sunrpc in 2.6.14-rc2-mm1 (and other -mm versions) Max Kellermann
2005-09-22 19:27 ` Andrew Morton [this message]
[not found] <mailman.1127394541.15384.linux-kernel2news@redhat.com>
2005-09-22 14:02 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050922122749.555e0068.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=avuton@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=max@duempel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox