From: Christoph Hellwig <hch@infradead.org>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: wensong@linux-vs.org, linux-kernel@vger.kernel.org,
akpm@osdl.org, ja@ssi.bg
Subject: Re: [PATCH] reduce sizeof(struct file)
Date: Fri, 23 Sep 2005 11:05:41 +0100 [thread overview]
Message-ID: <20050923100541.GA18447@infradead.org> (raw)
In-Reply-To: <4333D2AA.6020009@cosmosbay.com>
On Fri, Sep 23, 2005 at 12:02:18PM +0200, Eric Dumazet wrote:
> Hi all
>
> Now that RCU applied on 'struct file' seems stable, we can place f_rcuhead
> in a memory location that is not anymore used at call_rcu(&f->f_rcuhead,
> file_free_rcu) time, to reduce the size of this critical kernel object.
>
> The trick I used is to move f_rcuhead and f_list in an union and defining
> macros to access f_list and f_rcuhead
>
> Unfortunatly f_list was also used in IPVS so I had to change
> include/net/ip_vs.h and net/ipv4/ipvs/ip_vs_ctl.c, changing their f_list to
> ipvs_f_list to avoid name clash.
>
> (This is why I send this mail to IPVS maintainers)
Please just change all callers to use the union, there's not very many
of them.
next prev parent reply other threads:[~2005-09-23 10:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-23 8:34 How to Force PIO mode on sata promise (Linux 2.6.10) David Sanchez
2005-09-23 9:47 ` Clemens Koller
2005-09-23 10:02 ` [PATCH] reduce sizeof(struct file) Eric Dumazet
2005-09-23 10:05 ` Christoph Hellwig [this message]
2005-09-23 23:30 ` J.A. Magallon
2005-09-24 0:09 ` Jesper Juhl
2005-09-24 0:19 ` Al Viro
2005-09-24 3:43 ` Eric Dumazet
2005-09-25 1:43 ` Nick Piggin
2005-09-30 0:32 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050923100541.GA18447@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=dada1@cosmosbay.com \
--cc=ja@ssi.bg \
--cc=linux-kernel@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox