Re: [swsusp] Rework image freeing

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Friday, 23 of September 2005 22:52, Rafael J. Wysocki wrote:
> Hi,
> 
> On Thursday, 22 of September 2005 11:46, Pavel Machek wrote:
> > Hi!
> > 
> > > > -
> > > > -/**
> > > > - *	calc_nr - Determine the number of pages needed for a pbe list.
> > > > - */
> > > > -
> > > > -static int calc_nr(int nr_copy)
> > > > -{
> > > > -	return nr_copy + (nr_copy+PBES_PER_PAGE-2)/(PBES_PER_PAGE-1);
> > > > -}
> > > 
> > > I can't see why you are going to drop this function.  Isn't it necessary any more?
> > 
> > I've actually decreased on-disk memory requirements by... guess what:
> > (nr_copy+PBES_PER_PAGE-2)/(PBES_PER_PAGE-1) factor. I do not store two
> > copies of page directories any more.
> 
> On-disk - yes, but we still need to allocate RAM to create the "pagedir".
> It takes ca (nr_copy_pages/(PBS_PER_PAGE-1) + !!(nr_copy_pages % (PBS_PER_PAGE-1))),

Sorry, this is not the right number, of course.  Should be
(nr_copy_pages/PBS_PER_PAGE + !!(nr_copy_pages % PBS_PER_PAGE))

Greetings,
Rafael


-- 
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
		-- Lewis Carroll "Alice's Adventures in Wonderland"