public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* RE: [patch 2.6.13 0/6] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device}
@ 2005-09-23 18:27 Luck, Tony
  2005-09-23 18:50 ` John W. Linville
                   ` (2 more replies)
  0 siblings, 3 replies; 17+ messages in thread
From: Luck, Tony @ 2005-09-23 18:27 UTC (permalink / raw)
  To: John W. Linville, Christoph Hellwig, linux-kernel, discuss,
	linux-ia64, ak, Mallick, Asit K

>> It should just go away once the GFP_DMA32 code is merged.
>
>Is that the plan?  I suppose it makes sense.
>
>So, move it to driver/pci/swiotlb.c?  Or just leave it where it is?
>
>Either way, I'll redo the other patches to reflect the correct
>location.

I don't have a good (or in fact any) understanding of the impact
of GFP_DMA32 on ia64.  People tell me it will all be good, but I'd
like to hear from someone running it.

If it is good, and if it is coming soon, then there is no point
moving swiotlb.  But I don't know the answers to either of those
questions.

-Tony

^ permalink raw reply	[flat|nested] 17+ messages in thread
* RE: [patch 2.6.13 0/6] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device}
@ 2005-09-22 20:37 Luck, Tony
  2005-09-22 20:41 ` Christoph Hellwig
  0 siblings, 1 reply; 17+ messages in thread
From: Luck, Tony @ 2005-09-22 20:37 UTC (permalink / raw)
  To: John W. Linville, linux-kernel, discuss, linux-ia64; +Cc: ak, Mallick, Asit K

>Conduct some maintenance of the swiotlb code:
>
>	-- Move the code from arch/ia64/lib to lib

I agree that this code needs to move up out of arch/ia64, it is messy
that x86_64 needs to reach over and grab this from arch/ia64.

But is "lib" really the right place for it to move to?  Perhaps
a more logical place might be "drivers/pci/swiotlb/" since this
code is tightly coupled to pci?

-Tony

^ permalink raw reply	[flat|nested] 17+ messages in thread
* Re: [patch 2.6.13] swiotlb: add swiotlb_sync_single_range_for_{cpu,device}
@ 2005-08-30 18:09 John W. Linville
  2005-09-12 14:48 ` [patch 2.6.13 0/6] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} John W. Linville
  0 siblings, 1 reply; 17+ messages in thread
From: John W. Linville @ 2005-08-30 18:09 UTC (permalink / raw)
  To: Luck, Tony
  Cc: linux-kernel, Andi Kleen, discuss, linux-ia64, Asit.K.Mallick,
	goutham.rao, davidm

On Tue, Aug 30, 2005 at 11:03:35AM -0700, Luck, Tony wrote:
> 
> >+swiotlb_sync_single_range_for_cpu(struct device *hwdev, 
> >+swiotlb_sync_single_range_for_device(struct device *hwdev, 
> 
> Huh?  These look identical ... same args, same code, just a
> different name.

Have you looked at the implementations for swiotlb_sync_single_for_cpu
and swiotlb_sync_single_for_device?  Those are already identical.

I'm just following the existing style/practice in that file.  I could
do an additional patch to rectify the replication in those functions
if you'd like?

Who is responsible for the swiotlb code?

John
-- 
John W. Linville
linville@tuxdriver.com

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2005-09-26 21:55 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-23 18:27 [patch 2.6.13 0/6] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} Luck, Tony
2005-09-23 18:50 ` John W. Linville
2005-09-23 21:38   ` Grant Grundler
2005-09-26  7:01 ` Andi Kleen
2005-09-26 21:01 ` [patch 2.6.14-rc2 0/5] " John W. Linville
2005-09-26 21:01   ` [patch 2.6.14-rc2 1/5] swiotlb: move from arch/ia64/lib to drivers/pci John W. Linville
2005-09-26 21:01     ` [patch 2.6.14-rc2 2/5] swiotlb: cleanup some code duplication cruft John W. Linville
2005-09-26 21:01       ` [patch 2.6.14-rc2 3/5] swiotlb: support syncing sub-ranges of mappings John W. Linville
2005-09-26 21:01         ` [patch 2.6.14-rc2 4/5] swiotlb: support syncing DMA_BIDIRECTIONAL mappings John W. Linville
2005-09-26 21:01           ` [patch 2.6.14-rc2 5/5] swiotlb: file header comments John W. Linville
2005-09-26 21:33   ` [patch 2.6.14-rc2 0/5] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} Matthew Wilcox
2005-09-26 21:54     ` John W. Linville
  -- strict thread matches above, loose matches on Subject: below --
2005-09-22 20:37 [patch 2.6.13 0/6] " Luck, Tony
2005-09-22 20:41 ` Christoph Hellwig
2005-09-23 18:22   ` John W. Linville
2005-09-23 18:31     ` Muli Ben-Yehuda
2005-08-30 18:09 [patch 2.6.13] swiotlb: add swiotlb_sync_single_range_for_{cpu,device} John W. Linville
2005-09-12 14:48 ` [patch 2.6.13 0/6] swiotlb maintenance and x86_64 dma_sync_single_range_for_{cpu,device} John W. Linville

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox