From: Al Viro <viro@ftp.linux.org.uk>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Anton Altaparmakov <aia21@cam.ac.uk>,
linux-kernel@vger.kernel.org,
linux-ntfs-dev@lists.sourceforge.net
Subject: Re: [PATCH 1/4] NTFS: Fix sparse warnings that have crept in over time.
Date: Mon, 26 Sep 2005 17:44:13 +0100 [thread overview]
Message-ID: <20050926164413.GP7992@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.58.0509260746130.3308@g5.osdl.org>
On Mon, Sep 26, 2005 at 07:57:09AM -0700, Linus Torvalds wrote:
> #define MFT_REF_MASK_CPU 0x0000ffffffffffffULL
> #define MFT_REF_MASK_LE const_cpu_to_le64(MFT_REF_MASK_CPU)
>
> instead. That way the type of that thing is well-defined.
Or just make those two different enums. Basically, gcc is hopelessly
b0rken in version-dependent way when it comes to multi-element enums
that get outside of int range. Single-element ones at least have
kinda-sorta consistent semantics; anything beyond that and you are
walking into very nasty areas.
prev parent reply other threads:[~2005-09-26 16:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-26 13:31 [2.6.14-rc2-git] NTFS: Even more bug fixes! Anton Altaparmakov
2005-09-26 13:32 ` [PATCH 1/4] NTFS: Fix sparse warnings that have crept in over time Anton Altaparmakov
2005-09-26 13:33 ` [PATCH 2/4] NTFS: Change ntfs_cluster_free() to require a write locked runlist on entry Anton Altaparmakov
2005-09-26 13:33 ` [PATCH 3/4] NTFS: Fix the definition of the CHKD ntfs record magic Anton Altaparmakov
2005-09-26 13:34 ` [PATCH 4/4] NTFS: More $LogFile handling fixes: when chkdsk has been run, it can leave the Anton Altaparmakov
2005-09-26 14:57 ` [PATCH 1/4] NTFS: Fix sparse warnings that have crept in over time Linus Torvalds
2005-09-26 16:09 ` Anton Altaparmakov
2005-09-26 16:41 ` Linus Torvalds
2005-09-26 16:46 ` Al Viro
2005-09-26 19:08 ` Anton Altaparmakov
2005-09-26 20:43 ` Linus Torvalds
2005-09-26 16:44 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050926164413.GP7992@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=aia21@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox