Re: [PATCH][Fix] Fix Bug #4959 (take 2)

Rafael J. Wysocki
2005-09-28T08:25:34Z

Hi,

On Wednesday, 28 of September 2005 01:43, Pavel Machek wrote:
> Hi!
>
> > > > I can reserve the static buffer (10 pages) in suspend.c and mark it as nosave.
> > > > The code that creates the mappings can stay in suspend.c either except it
> > > > won't need to call get_usable_page() and free_eaten_memory() any more
> > > > (__next_page() can be changed to get pages from the static buffer instead
> > > > of allocating them). The code can also be simplified a bit, as we assume that
> > > > there will be only one PGD entry in the direct mapping.
> > > >
> > > > If that sounds good to you, please confirm.
> > >
> > > 8GB limit seems good to me -- as long as it makes code significantly
> > > simpler. It would be nice if it was <20 lines.
> >
> > It is more than that, but it seems to be quite simple anyway.
> >
> > The new patch follows.
>
> Thanks, seems okay to me.

Thanks for reviewing.

If you don't mind, I'll change arch_prepare_suspend() a bit so that the
RAM sizes are printed in KB and repost the patch with a changelog.

Greetings,
Rafael