Re: [PATCH] m32r: set CHECKFLAGS properly

Sam Ravnborg
2005-09-27T20:01:42Z

> Sam, any help in that area? Ideally we want to have something equivalent
> to
> PREDEFINED_WE_MIGHT_WANT = __m32r__ __LITTLE_ENDIAN__ __BIG_ENDIAN__
> and CHECKFLAGS done from that - basically, the subset of cross-gcc
> predefined symbols reproduced for sparse. Ideally with -m64 added
> if we have sizeof(long) == 8 on target, to take care of all that
> crap in one go.
>
> Suggestions?
The most simple solution would be to provide a small script that
create the defines as we need and run it for each invocation of sparse.
The script should use same trick as scripts/gcc-version.sh does.

So we could have:
#!/bin/sh
compiler="$*"

BIG=$(echo __BIG_ENDIAN__ | $compiler -E -xc - | tail -n 1)
LITTLE=$(echo __LITTLE_ENDIAN__ | $compiler -E -xc - | tail -n 1)

Then BIG would be set to "1" if this is big endian, and "__BIG_ENDIAN__"
if little endian.
A little bit of shell script and we have the defines we want for m32r.
Then we could add calling this script as part of sparse invocation.

The better solution would be to find the relevant flags before we
start building the kernel. This is not so easy if we want access to
final CFLAGS. But for the architecture the important ones are
defined in arch/Makefile so placing this late in the file and
use $(CC) $(CFLAGS) should be OK in almost all cases.

Too late for me to cook up a patch right now - but simple.
Oh, and I agree. We do NOT want all the gcc defined flags.

We should restrict to a subset in the kernel - so it's good
if sparse warns/errors out on usage of the non-trivial defines.
Sam