Re: [PATCH] m32r: set CHECKFLAGS properly

Linus Torvalds
2005-09-27T15:00:29Z

On Tue, 27 Sep 2005, Hirokazu Takata wrote:
>
> Now, the endianness is to be determined by a (cross)compiler:
> - For the big-endian, a compiler (m32r-linux-gcc or m32r-linux-gnu-gcc)
> provides a predefined macro __BIG_ENDIAN__.
> - For little-endian, a compiler (m32rle-linux-gcc or m32rle-linux-gnu-gcc)
> provides a predefined macro __LITTLE_ENDIAN__.

Hmm.. You need to tell sparse _some_ way which one you use, since sparse
won't do it.

Picking one at random is fine, of course. It doesn't even have to match
the one you'll compile with, although that means that sparse will
obviously be testing a different configuration than the one you'd actually
compile.

So I think having -D__BIG_ENDIAN__ in the sparse flags is better than not
having anything at all (since otherwise it won't be able to check
anything). And having something that matches the compiler would be better
still.

Linus