public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Hirokazu Takata <takata@linux-m32r.org>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m32r: set CHECKFLAGS properly
Date: Thu, 29 Sep 2005 02:56:29 +0100	[thread overview]
Message-ID: <20050929015629.GP7992@ftp.linux.org.uk> (raw)
In-Reply-To: <20050928.190414.189705294.takata.hirokazu@renesas.com>

On Wed, Sep 28, 2005 at 07:04:14PM +0900, Hirokazu Takata wrote:
> In the top Makefile, CHECKFLAGS is defined as follows:
> CHECKFLAGS     := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ $(CF)
> 
> Can I use CF for user specific CHECKFLAGS ?
> What do you think about we specify it manyally for a biendian target?
> 
> ex. m32r
>   sparse check for biendian target
>   $ make ARCH=m32r CF=-D__BIG_ENDIAN__=1 C=1   ... for big-endian
>   $ make ARCH=m32r CF=-D__LITTLE__=1 C=1       ... for little-endian

That's doable, but...  I'd rather not make it mandatory - CF is for
"specific for this build" flags and when used for parallel cross-builds
such requirements make it rather nasty to deal with.
 
> I understand what you said.
> I think having -D__BIG_ENDIAN__ is one of the realistic solutions,
> because it seems that there is no good solution about this problem
> as other people said in this ML-thread.

Note that it's not just sparse.  There is a legitimate need to make
endianness of target visible to Kconfig - not to mention anything
else, there are drivers that are really broken on big-endian targets.

  reply	other threads:[~2005-09-29  1:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-26  5:18 [PATCH] m32r: set CHECKFLAGS properly Al Viro
2005-09-27  6:13 ` Hirokazu Takata
2005-09-27  7:10   ` Al Viro
2005-09-27 15:13     ` Kyle Moffett
2005-09-27 16:34       ` Al Viro
2005-09-27 17:31         ` Kyle Moffett
2005-09-27 17:55           ` Al Viro
2005-09-27 18:37             ` Kyle Moffett
2005-09-27 23:06               ` Al Viro
2005-09-27 20:02     ` Sam Ravnborg
2005-09-28  1:44       ` Al Viro
2005-09-27  6:23 ` Hirokazu Takata
2005-09-27 15:00   ` Linus Torvalds
2005-09-28  0:18     ` Al Viro
2005-09-28 10:04       ` Hirokazu Takata
2005-09-29  1:56         ` Al Viro [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-09-26  5:19 Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050929015629.GP7992@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=takata@linux-m32r.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox