Re: [RFC][patch 2.6.14-rc2] dell_rbu: Changing packet update mechanism

[Jesper Juhl <jesper.juhl@gmail.com>]

On Friday 23 September 2005 21:40, Abhay Salunke wrote:
> Please ignore earlier patches as there was error submitting it! :-(
> patch below is good...
> 

Ok, I'm being pedantic. So shoot me.
There are a few tiny bits CodingStyle wise that could be better. No big deal,
I'm nitpicking in the extreme here...


[snip]
> -	pr_debug("fill_last_packet: entry \n");

	pr_debug("fill_last_packet: entry\n");


[snip]
> -	pr_debug("fill_last_packet: exit \n");

	pr_debug("fill_last_packet: exit\n");


[snip]
>  	pr_debug("create_packet: exit \n");

	pr_debug("create_packet: exit\n");


[snip]
> +	temp = (u8 *) data;

	temp = (u8 *)data;


[snip]
> +do_packet_read(char *data, struct list_head *ptemp_list,
>  	int length, int bytes_read, int *list_read_count)

Hmm, I believe the prefered style for functions is to indent parameters that
won't fit on the first line by two tab stops, like this : 

do_packet_read(char *data, struct list_head *ptemp_list,
		int length, int bytes_read, int *list_read_count)

There are several occourences of this.


[snip]
> +packet_read_list(char *data, size_t * pread_length)

packet_read_list(char *data, size_t *pread_length)

[snip]
>   * img_update_free: Frees the buffer allocated for storing BIOS image
>   * Always called with lock held and returned with lock held

 * Always called with lock held and returned with lock held.


[snip]
> +	.attr = {.name = "data",.owner = THIS_MODULE,.mode = 0444},

	.attr = {.name = "data", .owner = THIS_MODULE, .mode = 0444},


[snip]
> +	.attr = {.name = "image_type",.owner = THIS_MODULE,.mode = 0644},

	.attr = {.name = "image_type", .owner = THIS_MODULE, .mode = 0644},


[snip]
> +	.attr = {.name = "packet_size",.owner = THIS_MODULE,.mode = 0644},

	.attr = {.name = "packet_size", .owner = THIS_MODULE, .mode = 0644},



-- 
Jesper Juhl <jesper.juhl@gmail.com>