public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: linux-sh@m17n.org
Cc: linux-kernel@vger.kernel.org
Subject: [RFC] breakage either in arch/sh/Kconfig or arch/sh/kernel/process.c?
Date: Thu, 29 Sep 2005 07:12:39 +0100	[thread overview]
Message-ID: <20050929061239.GS7992@ftp.linux.org.uk> (raw)

In process.c:
void flush_thread(void)
{
#if defined(CONFIG_SH_FPU)
        struct task_struct *tsk = current;
        struct pt_regs *regs = (struct pt_regs *)
                                ((unsigned long)tsk->thread_info
                                 + THREAD_SIZE - sizeof(struct pt_regs)
                                 - sizeof(unsigned long));
...
and
int dump_task_regs(struct task_struct *tsk, elf_gregset_t *regs)
{
        struct pt_regs ptregs;

        ptregs = *(struct pt_regs *)
                ((unsigned long)tsk->thread_info + THREAD_SIZE
                 - sizeof(struct pt_regs)
#ifdef CONFIG_SH_DSP
                 - sizeof(struct pt_dspregs)
#endif
                 - sizeof(unsigned long));

which is obviously inconsistent if we ever build with both SH_FPU and SH_DSP
set.  Now, in arch/sh/Kconfig we see that SH_FPU depends on !CPU_SH3 and SH_DSP
on !CPU_SH4.  Which leaves CPU_SH2 picking both options.

Comments?  Looks like either Kconfig or flush_thread() needs fixing...

             reply	other threads:[~2005-09-29  6:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-29  6:12 Al Viro [this message]
2005-09-29  6:31 ` [RFC] breakage either in arch/sh/Kconfig or arch/sh/kernel/process.c? Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050929061239.GS7992@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@m17n.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox