From: Prasanna S Panchamukhi <prasanna@in.ibm.com>
To: Andi Kleen <ak@suse.de>
Cc: "Zhang, Yanmin" <yanmin.zhang@intel.com>,
linux-kernel@vger.kernel.org, discuss@x86-64.org,
systemtap@sources.redhat.com, "Keshavamurthy,
Anil S" <anil.s.keshavamurthy@intel.com>
Subject: Re: [discuss] [PATCH] utilization of kprobe_mutex is incorrect on x86_64
Date: Thu, 29 Sep 2005 19:43:41 +0530 [thread overview]
Message-ID: <20050929141341.GA10273@in.ibm.com> (raw)
>On Thu, Sep 29, 2005 at 08:43:44AM +0800, Zhang, Yanmin wrote:
>> <<kprobe_incorrect_kprobe_mutex_2.6.14-rc2_x86_64.patch>> I found it
>> when reading the source codes. Basically, the bug could break
>> kprobe_insn_pages under multi-thread environment. PPC arch also has the
>> problem.
>Can you describe what the problem actually is?
Andi,
The up()/down() orders are incorrect in arch/x86_64/kprobes.c file while
trying to get/remove a kprobes instruction slot in arch_prepare_kprobe()
and arch_remove_kprobe() routines. Zhang's patch corrects this.
Thanks
Prasanna
--
Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Ph: 91-80-25044636
<prasanna@in.ibm.com>
next reply other threads:[~2005-09-29 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-29 14:13 Prasanna S Panchamukhi [this message]
2005-09-29 14:31 ` [discuss] [PATCH] utilization of kprobe_mutex is incorrect on x86_64 Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2005-09-30 6:34 Zhang, Yanmin
2005-09-29 0:43 Zhang, Yanmin
2005-09-29 13:15 ` [discuss] " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050929141341.GA10273@in.ibm.com \
--to=prasanna@in.ibm.com \
--cc=ak@suse.de \
--cc=anil.s.keshavamurthy@intel.com \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=systemtap@sources.redhat.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox