From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751333AbVI2VTr (ORCPT ); Thu, 29 Sep 2005 17:19:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751334AbVI2VTr (ORCPT ); Thu, 29 Sep 2005 17:19:47 -0400 Received: from rwcrmhc11.comcast.net ([216.148.227.117]:65020 "EHLO rwcrmhc11.comcast.net") by vger.kernel.org with ESMTP id S1751333AbVI2VTq (ORCPT ); Thu, 29 Sep 2005 17:19:46 -0400 Date: Thu, 29 Sep 2005 14:20:55 -0700 From: Deepak Saxena To: Linus Torvalds , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH] Fix IXP4xx MTD driver no cast warning Message-ID: <20050929212055.GA311@plexity.net> Reply-To: dsaxena@plexity.net References: <20050929195205.GA30002@plexity.net> <20050929205252.GG7684@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050929205252.GG7684@flint.arm.linux.org.uk> Organization: Plexity Networks User-Agent: Mutt/1.5.10i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sep 29 2005, at 21:52, Russell King was caught saying: > On Thu, Sep 29, 2005 at 12:52:05PM -0700, Deepak Saxena wrote: > > Fix following warning: > > > > drivers/mtd/maps/ixp4xx.c: In function 'ixp4xx_flash_probe': > > drivers/mtd/maps/ixp4xx.c:199: warning: assignment makes integer from > > pointer without a cast > > > > Signed-off-by: Deepak Saxena > > > > diff --git a/drivers/mtd/maps/ixp4xx.c b/drivers/mtd/maps/ixp4xx.c > > --- a/drivers/mtd/maps/ixp4xx.c > > +++ b/drivers/mtd/maps/ixp4xx.c > > @@ -196,7 +196,7 @@ static int ixp4xx_flash_probe(struct dev > > goto Error; > > } > > > > - info->map.map_priv_1 = ioremap(dev->resource->start, > > + info->map.map_priv_1 = (unsigned long)ioremap(dev->resource->start, > > Shouldn't this be using info->map.virt instead of the old map.map_priv_1 ? I think when I wrote this, having a !0 value in map->virt would cause the mtd core to assume that the map driver supported point()ing and direct copy of data. Looking at the mtd code it looks like this assumption might have gone away...will change code. ~Deepak -- Deepak Saxena - dsaxena@plexity.net - http://www.plexity.net Even a stopped clock gives the right time twice a day.