[PATCH 05/10] [PATCH]: Missing acct/mm calls in compat_do_execve()

Chris Wright
2005-09-30T02:24:00Z

[-- Attachment #1: missing-acct-mm-calls-in-compat_do_execve.patch --]
[-- Type: text/plain, Size: 1292 bytes --]

-stable review patch. If anyone has any objections, please let us know.
------------------

As I do periodically, I checked to see how far out of sync
compat_do_execve() has gotten from do_execve(). And as usual there
was some missing stuff in the former. Perhaps we need some tighter
consolidation of these two routines to make this less likely to happen
in the future.

Anyways, on the success path of compat_do_execve() we forget
to call acct_update_integrals() and update_mem_hiwater(), as
is done in do_execve().

Signed-off-by: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@osdl.org>
---
fs/compat.c | 4 ++++
1 files changed, 4 insertions(+)

Index: linux-2.6.13.y/fs/compat.c
===================================================================
--- linux-2.6.13.y.orig/fs/compat.c
+++ linux-2.6.13.y/fs/compat.c
@@ -44,6 +44,8 @@
#include <linux/nfsd/syscall.h>
#include <linux/personality.h>
#include <linux/rwsem.h>
+#include <linux/acct.h>
+#include <linux/mm.h>

#include <net/sock.h> /* siocdevprivate_ioctl */

@@ -1567,6 +1569,8 @@ int compat_do_execve(char * filename,

/* execve success */
security_bprm_free(bprm);
+ acct_update_integrals(current);
+ update_mem_hiwater(current);
kfree(bprm);
return retval;
}

--