Re: [RFC: 2.6 patch] net/sunrpc/: possible cleanups

Adrian Bunk
2005-10-02T14:41:19Z

On Sat, Oct 01, 2005 at 08:40:19PM +0400, Alexey Dobriyan wrote:
> On Sat, Oct 01, 2005 at 04:20:41PM +0200, Adrian Bunk wrote:
> > -/* Just increments the mechanism's reference count and returns its input: */
> > -struct gss_api_mech * gss_mech_get(struct gss_api_mech *);
> > -
>
> > -struct gss_api_mech *
> > +static struct gss_api_mech *
> > gss_mech_get(struct gss_api_mech *gm)
>
> Comment is lost.

The comment made sense for the prototype at the header, but the function
now has only one caller in the file where it's defined.

If someone needs a comment to figure out what a function whose complete
contents is

static struct gss_api_mech *
gss_mech_get(struct gss_api_mech *gm)
{
__module_get(gm->gm_owner);
return gm;
}

does, the problem is not a missing comment.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed