Re: [PATCH 1/7] AMD Geode GX/LX support

[Adrian Bunk <bunk@stusta.de>]

On Mon, Oct 03, 2005 at 11:47:38AM -0600, Jordan Crouse wrote:
> This patch adds support for the GX processor including processor
> identification, and enabling / disabling the appropriate configuration
> options.  Please apply against linux-2.4.14-rc2-mm2.
> 
> Signed off by:  Jordan Crouse (jordan.crouse@amd.com)
> 
> Index: linux-2.6.14-rc2-mm2/MAINTAINERS
> ===================================================================
> --- linux-2.6.14-rc2-mm2.orig/MAINTAINERS
> +++ linux-2.6.14-rc2-mm2/MAINTAINERS
> @@ -259,6 +259,13 @@ P:	Ivan Kokshaysky
>  M:	ink@jurassic.park.msu.ru
>  S:	Maintained for 2.4; PCI support for 2.6.
>  
> +AMD GEODE PROCESSOR/CHIPSET SUPPORT
> +P:
> +M:
> +L:	info-linux@geode.amd.com
> +W:	http://www.amd.com/us-en/ConnectivitySolutions/TechnicalResources/0,,50_2334_2452_11363,00.html
> +S:	Supported
>...

Could you add yourself in the P: and M: lines?

> +config MGEODE_GX
> +	bool "Geode GX"
> +	help
> +	  Select this for AMD Geode GX processors.  Enables use of some extended
> +	  instructions, and passes appropriate optimization flags to GCC.
>...

The "and passes appropriate optimization flags to GCC" part seems to be 
missing in your patches.

And it's not clear to me how your new MGEODE_GX option relates to the 
already existing MGEODEGX1 option.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed