Re: [2.6 patch] kill include/linux/platform.h

[Adrian Bunk <bunk@stusta.de>]

On Mon, Oct 03, 2005 at 12:01:08PM -0700, Tony Luck wrote:
> > --- linux-2.6.14-rc2-mm2-full/arch/ia64/kernel/setup.c.old      2005-10-02 01:09:11.000000000 +0200
> > +++ linux-2.6.14-rc2-mm2-full/arch/ia64/kernel/setup.c  2005-10-02 01:09:15.000000000 +0200
> > @@ -41,7 +41,6 @@
> >  #include <linux/serial_core.h>
> >  #include <linux/efi.h>
> >  #include <linux/initrd.h>
> > -#include <linux/platform.h>
> >  #include <linux/pm.h>
> >
> >  #include <asm/ia32.h>
> 
> NAK.  Without <linux/platform.h> ia64 doesn't compile:
> 
>   CC      arch/ia64/kernel/setup.o
> arch/ia64/kernel/setup.c: In function `cpu_init':
> arch/ia64/kernel/setup.c:855: error: `default_idle' undeclared (first
> use in this function)
> arch/ia64/kernel/setup.c:855: error: (Each undeclared identifier is
> reported only once
> arch/ia64/kernel/setup.c:855: error: for each function it appears in.)
> make[1]: *** [arch/ia64/kernel/setup.o] Error 1
> make: *** [arch/ia64/kernel] Error 2
> 
> So you will need to add a:
> 
> extern void default_idle(void );
> 
> some place in setup.c to fix this.

The default_idle() prototype should stay inside some header file.

@Patrick:
Any suggestion where it should move to?

> -Tony

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed