public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Jordan Crouse <jordan.crouse@amd.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: AMD Geode GX/LX support
Date: Wed, 5 Oct 2005 21:26:08 +0200	[thread overview]
Message-ID: <20051005192608.GB3847@stusta.de> (raw)
In-Reply-To: <20051003194655.GA30975@cosmic.amd.com>

On Mon, Oct 03, 2005 at 01:46:55PM -0600, Jordan Crouse wrote:
> > > +config MGEODE_GX
> > > +	bool "Geode GX"
> > > +	help
> > > +	  Select this for AMD Geode GX processors.  Enables use of some extended
> > > +	  instructions, and passes appropriate optimization flags to GCC.
> > >...
> > 
> > The "and passes appropriate optimization flags to GCC" part seems to be 
> > missing in your patches.
> 
> Yes - that is incorrect.  As you can no doubt see, I cut-n-pasted from
> another processor.
>...

Why don't you set any compiler flags?

I'd assume that there is one compiler flag usually producing the best 
code for the CPU.

> Thanks for your comments,
> Jordan

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2005-10-05 19:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-03 17:47 [PATCH 1/7] AMD Geode GX/LX support Jordan Crouse
2005-10-03 18:05 ` Adrian Bunk
2005-10-03 19:46   ` Jordan Crouse
2005-10-05 19:26     ` Adrian Bunk [this message]
2005-10-03 18:08 ` [PATCH 1/7] " Zwane Mwaikambo
2005-10-03 19:01 ` Alan Cox
2005-10-03 19:55   ` Jordan Crouse
2005-10-03 20:46     ` Alan Cox
2005-10-03 22:22       ` Jordan Crouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051005192608.GB3847@stusta.de \
    --to=bunk@stusta.de \
    --cc=jordan.crouse@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox