[PATCH 2.6.14-rc3] sis190.c: fix multicast MAC filter

[PATCH 2.6.14-rc3] sis190.c: fix multicast MAC filter

[Aurelien Jarno]

Hi,

Here is a patch that changes the way the MAC filter is computed for the
multicast addresses. The computation is taken from the SiS GPL driver. 

This patch is necessary to get IPv6 working.

Thanks,
Aurelien


Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

--- linux-2.6.14-rc3-git4.orig/drivers/net/sis190.c	2005-10-05 22:06:51.000000000 +0200
+++ linux-2.6.14-rc3-git4/drivers/net/sis190.c	2005-10-05 22:12:05.000000000 +0200
@@ -842,7 +842,7 @@
 		for (i = 0, mclist = dev->mc_list; mclist && i < dev->mc_count;
 		     i++, mclist = mclist->next) {
 			int bit_nr =
-				ether_crc(ETH_ALEN, mclist->dmi_addr) >> 26;
+				ether_crc(ETH_ALEN, mclist->dmi_addr) & 0x3f;
 			mc_filter[bit_nr >> 5] |= 1 << (bit_nr & 31);
 			rx_mode |= AcceptMulticast;
 		}


-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

Re: [PATCH 2.6.14-rc3] sis190.c: fix multicast MAC filter

[Francois Romieu]

Aurelien Jarno <aurelien@aurel32.net> :
> Here is a patch that changes the way the MAC filter is computed for the
> multicast addresses. The computation is taken from the SiS GPL driver. 

Ok.

[...]
> This patch is necessary to get IPv6 working.

May I assume that it has been tested on the usual k8s-mx ?

If so, feel free to forward to jgarzik@pobox.com and netdev@vger.kernel.org.
I've just bought a mobo to test this adapter but it will not be ready before
this week end.

--
Ueimor

Re: [PATCH 2.6.14-rc3] sis190.c: fix multicast MAC filter

[Aurelien Jarno]

On Wed, Oct 05, 2005 at 11:05:52PM +0200, Francois Romieu wrote:
> Aurelien Jarno <aurelien@aurel32.net> :
> > Here is a patch that changes the way the MAC filter is computed for the
> > multicast addresses. The computation is taken from the SiS GPL driver. 
> 
> Ok.
> 
> [...]
> > This patch is necessary to get IPv6 working.
> 
> May I assume that it has been tested on the usual k8s-mx ?

Yes, you're right.

> If so, feel free to forward to jgarzik@pobox.com and netdev@vger.kernel.org.
> I've just bought a mobo to test this adapter but it will not be ready before
> this week end.

Ok, will do that.

Thanks,
Aurelien

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net