* Re: clone: I'm only doing a max of 256 requests
[not found] ` <7vhdbvk6ln.fsf@assigned-by-dhcp.cox.net>
@ 2005-10-05 21:38 ` Junio C Hamano
2005-10-05 22:27 ` Vincent Hanquez
2005-10-05 22:48 ` Linus Torvalds
0 siblings, 2 replies; 3+ messages in thread
From: Junio C Hamano @ 2005-10-05 21:38 UTC (permalink / raw)
To: git; +Cc: linux-kernel
Junio C Hamano <junkio@cox.net> writes:
> 1. As a stop gap measure, so that your Linux kernel work can
> continue, please bump MAX_NEEDS definition in upload-pack.c
> from 256 to a bit higher. That controls the number of
> 40-letter SHA1 given to underlying rev-list via execvp(), so
> it cannot be _too_ big like 1M, lest it exceeds the exec
> argument buffer limit.
Hmph. I was reading linux-2.6/fs/exec.c::copy_strings(), but I
do not see any such size limit (other than exceeding the total
machine memory size, probably reported by alloc_page() failing)
imposed there. Am I looking at the wrong place?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: clone: I'm only doing a max of 256 requests
2005-10-05 21:38 ` clone: I'm only doing a max of 256 requests Junio C Hamano
@ 2005-10-05 22:27 ` Vincent Hanquez
2005-10-05 22:48 ` Linus Torvalds
1 sibling, 0 replies; 3+ messages in thread
From: Vincent Hanquez @ 2005-10-05 22:27 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, linux-kernel
On Wed, Oct 05, 2005 at 02:38:42PM -0700, Junio C Hamano wrote:
> Hmph. I was reading linux-2.6/fs/exec.c::copy_strings(), but I
> do not see any such size limit (other than exceeding the total
> machine memory size, probably reported by alloc_page() failing)
> imposed there. Am I looking at the wrong place?
well at least the len of argv is limited by ~32K (i386) by:
bprm->p = PAGE_SIZE*MAX_ARG_PAGES-sizeof(void *);
...
bprm->argc = count(argv, bprm->p / sizeof(void *));
--
Vincent Hanquez
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: clone: I'm only doing a max of 256 requests
2005-10-05 21:38 ` clone: I'm only doing a max of 256 requests Junio C Hamano
2005-10-05 22:27 ` Vincent Hanquez
@ 2005-10-05 22:48 ` Linus Torvalds
1 sibling, 0 replies; 3+ messages in thread
From: Linus Torvalds @ 2005-10-05 22:48 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, linux-kernel
On Wed, 5 Oct 2005, Junio C Hamano wrote:
>
> Hmph. I was reading linux-2.6/fs/exec.c::copy_strings(), but I
> do not see any such size limit (other than exceeding the total
> machine memory size, probably reported by alloc_page() failing)
> imposed there. Am I looking at the wrong place?
Look for "MAX_ARG_PAGES".
Ie the limit is about 128kB by default (32 pages). Note that that includes
not just arguments, but environment.
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-10-05 22:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20051005191300.GC17475@hexapodia.org>
[not found] ` <7virwbu4wz.fsf@assigned-by-dhcp.cox.net>
[not found] ` <7vhdbvk6ln.fsf@assigned-by-dhcp.cox.net>
2005-10-05 21:38 ` clone: I'm only doing a max of 256 requests Junio C Hamano
2005-10-05 22:27 ` Vincent Hanquez
2005-10-05 22:48 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox