Re: [swsusp] separate snapshot functionality to separate file

[Pavel Machek <pavel@ucw.cz>]

On Čt 06-10-05 00:57:27, Pavel Machek wrote:
> On Čt 06-10-05 00:54:19, Lorenzo Colitti wrote:
> > Pavel Machek wrote:
> > >>- It was dog slow because it doesn't use compression
> > >>- Even though it's dog slow, it doesn't save all RAM
> > >>  - Therefore the machine is dog slow after resume
> > >>- It doesn't have a decent UI
> > >>- There is no way to abort suspend once it's started. [...]
> > >
> > >With uswsusp (aka swsusp3), you can do all this in userland. Stop
> > >whining, start hacking... Code is at kernel.org/git/.../linux-sw3.
> > 
> > But that was exactly my point: there's no need to hack!
> > 
> > The code is there. It's well tested, fast, stable, and does what users 
> > need. It's called suspend2. Why work on yet another implementation 
> > instead of just merging that?
> 
> Most of that code does not belong it kernel. It can't be "just
> merged". If we had nice "vi" implementation in kernel, we'd have to
> drop it and start again in userland. This is similar.

To say it more nicely.

"Cool, so you have done 100% of work and now it is stable, fast and
tested. You only need to do 200% more work to get it merged".

Merging into kernel is not easy, sorry.
								Pavel
-- 
if you have sharp zaurus hardware you don't need... you know my address