Re: [PATCH 20/22] PCI Error Recovery: e100 network device driver

linas
2005-10-11T23:04:14Z

On Mon, Oct 10, 2005 at 05:10:56PM -0700, Greg KH was heard to remark:
> On Thu, Oct 06, 2005 at 06:57:29PM -0500, linas wrote:
> > +config E100_EEH_RECOVERY
> > + bool "Enable PCI bus error recovery"
> > + depends on E100 && PPC_PSERIES
> > + help
> > + If you say Y here, the driver will be able to recover from
> > + PCI bus errors on many PowerPC platforms. IBM pSeries users
> > + should answer Y.
>
> Why make a config option for this at all? Who would turn it off?

I wanted to have this turned off for anyone who didn't have
hardware capable of supporting this, and didn't really think
about how to hide this from the menu. I guess its best to
just plain hide this, keep the menus from getting cluttered.

> > @@ -2661,6 +2731,9 @@
> > .resume = e100_resume,
> > #endif
> > .shutdown = e100_shutdown,
> > +#ifdef CONFIG_E100_EEH_RECOVERY
> > + .err_handler = &e100_err_handler,
> > +#endif /* CONFIG_E100_EEH_RECOVERY */
>
> No, don't put #ifdefs in the middle of a structure, remember we made
> err_handler always present in the .h file for a reason...

OK.

I'll send revised patches patches tommorrw, hiding the config, and
removing the ifdef.

--linas