Re: [PATCH 20/22] PCI Error Recovery: e100 network device driver

Greg KH
2005-10-11T00:11:39Z

On Thu, Oct 06, 2005 at 06:57:29PM -0500, linas wrote:
> +config E100_EEH_RECOVERY
> + bool "Enable PCI bus error recovery"
> + depends on E100 && PPC_PSERIES
> + help
> + If you say Y here, the driver will be able to recover from
> + PCI bus errors on many PowerPC platforms. IBM pSeries users
> + should answer Y.

Why make a config option for this at all? Who would turn it off?

> @@ -2661,6 +2731,9 @@
> .resume = e100_resume,
> #endif
> .shutdown = e100_shutdown,
> +#ifdef CONFIG_E100_EEH_RECOVERY
> + .err_handler = &e100_err_handler,
> +#endif /* CONFIG_E100_EEH_RECOVERY */

No, don't put #ifdefs in the middle of a structure, remember we made
err_handler always present in the .h file for a reason...

thanks,

greg k-h