From: Al Viro <viro@ftp.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@osdl.org, trond.myklebust@fys.uio.no, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] don't invalidate non-directory mountpoints
Date: Fri, 7 Oct 2005 15:30:13 +0100 [thread overview]
Message-ID: <20051007143012.GC7992@ftp.linux.org.uk> (raw)
In-Reply-To: <E1ENqAg-0004bJ-00@dorka.pomaz.szeredi.hu>
On Fri, Oct 07, 2005 at 01:13:50PM +0200, Miklos Szeredi wrote:
> d_invalidate allowed a non-directory mountpoint to be invalidated,
> which is bad, since the mountpoint becomes unreachable.
>
> I know it's racy wrt attaching/detaching mount, but AFAICS so is
> everything else that unhashes the dentry. This seems to be an
> oversight when splitting out vfsmount_lock from dcache_lock. To be
> fixed.
NAK. That's a wrong way to deal with the problem and it's much older
than vfsmount_lock or dcache_lock (and affects directories too).
next prev parent reply other threads:[~2005-10-07 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-07 11:13 [PATCH] don't invalidate non-directory mountpoints Miklos Szeredi
2005-10-07 14:30 ` Al Viro [this message]
2005-10-07 14:35 ` Miklos Szeredi
2005-10-07 14:41 ` Al Viro
2005-10-07 14:45 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051007143012.GC7992@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox