From: Al Viro <viro@ftp.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@osdl.org, trond.myklebust@fys.uio.no, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfs: don't drop dentry in d_revalidate
Date: Fri, 7 Oct 2005 15:38:50 +0100 [thread overview]
Message-ID: <20051007143850.GD7992@ftp.linux.org.uk> (raw)
In-Reply-To: <E1ENqHd-0004cW-00@dorka.pomaz.szeredi.hu>
On Fri, Oct 07, 2005 at 01:21:01PM +0200, Miklos Szeredi wrote:
> NFS d_revalidate() is doing things that are supposed to be done by
> d_invalidate().
>
> Dropping the dentry is especially bad, since it will make
> d_invalidate() bypass all checks.
NAK. _IF_ you are going to start playing with that area, start with
handling that stuff in caller before going after methods.
Note that the only relatively sane semantics is to have equivalent on
umount -l done to everything that becomes unreachable.
prev parent reply other threads:[~2005-10-07 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-07 11:21 [PATCH] nfs: don't drop dentry in d_revalidate Miklos Szeredi
2005-10-07 13:52 ` Trond Myklebust
2005-10-07 14:04 ` Miklos Szeredi
2005-10-07 14:38 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051007143850.GD7992@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox