public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Rosenkraenzer <bero@arklinux.org>
To: adaplas@users.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Modular i810fb broken, partial fix
Date: Fri, 7 Oct 2005 15:47:14 +0200	[thread overview]
Message-ID: <200510071547.14616.bero@arklinux.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

Hi,
i810fb as a module is broken (checked with 2.6.13-mm3 and 2.6.14-rc2-mm1).
It compiles, but the module doesn't actually load because the kernel doesn't 
recognize the hardware (the MODULE_DEVICE_TABLE statement is missing).

The attached patch fixes this.

However, the resulting module still doesn't work.
It loads, and then garbles the display (black screen with a couple of yellow 
lines, no matter what is written into the framebuffer device).

Related .config entries:
CONFIG_I2C_I810=m
CONFIG_FB_I810=m
CONFIG_FB_I810_GTF=y
CONFIG_FB_I810_I2C=y

[-- Attachment #2: 2.6.13-mm3-fix-i810fb.patch --]
[-- Type: text/x-diff, Size: 348 bytes --]

--- linux-2.6.13/drivers/video/i810/i810_main.c.ark	2005-09-13 00:31:37.000000000 +0200
+++ linux-2.6.13/drivers/video/i810/i810_main.c	2005-09-13 00:31:54.000000000 +0200
@@ -83,6 +83,8 @@
 	{ 0 },
 };
 
+MODULE_DEVICE_TABLE(pci, i810fb_pci_tbl);
+
 static struct pci_driver i810fb_driver = {
 	.name     =	"i810fb",
 	.id_table =	i810fb_pci_tbl,

             reply	other threads:[~2005-10-07 13:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-07 13:47 Bernhard Rosenkraenzer [this message]
2005-10-08 10:39 ` Modular i810fb broken, partial fix Antonino A. Daplas
2005-10-08 11:02   ` Bernhard Rosenkraenzer
2005-10-08 11:31   ` Giuseppe Bilotta
2005-10-08 13:03     ` Antonino A. Daplas
2005-10-08 14:51       ` Giuseppe Bilotta
2005-10-08 21:22         ` Antonino A. Daplas
2005-10-08 11:56   ` Manuel Lauss
2005-10-08 13:03     ` Antonino A. Daplas
2005-10-08 15:30       ` Manuel Lauss
2005-10-09 16:48         ` Bernhard Rosenkraenzer
2005-10-09 17:13           ` Manuel Lauss
2005-10-09 17:21           ` Manuel Lauss
2005-10-10  8:06           ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200510071547.14616.bero@arklinux.org \
    --to=bero@arklinux.org \
    --cc=adaplas@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox