From: linas <linas@austin.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc64-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] ppc64: EEH typos, include files, macros, whitespace
Date: Fri, 7 Oct 2005 14:46:44 -0500 [thread overview]
Message-ID: <20051007194644.GA29826@austin.ibm.com> (raw)
In-Reply-To: <17219.46319.501091.93202@cargo.ozlabs.ibm.com>
On Wed, Oct 05, 2005 at 09:11:43PM +1000, Paul Mackerras was heard to remark:
>
> This makes the line go over 80 columns, which seems unnecessary.
Hm, I code with tabstops set to 3, on a 132-column terminal.
It looked goofy there.
> > - * @token i/o token, should be address in the form 0xE....
> > + * @token i/o token, should be address in the form 0xA....
>
> I think the virtual addresses we get from ioremap these days start
> with 0xD00008...
Ah, didn't realize this changed. I was simultaneously debugging
a 2.4 kernel (for other reasons) when I noticed this.
--linas
next prev parent reply other threads:[~2005-10-07 19:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-30 0:48 [PATCH 0/7] ppc64: Assorted minor EEH cleanups linas
2005-09-30 0:51 ` [PATCH 1/7] ppc64: EEH typos, include files, macros, whitespace linas
2005-10-05 11:11 ` Paul Mackerras
2005-10-07 19:46 ` linas [this message]
2005-09-30 0:53 ` [PATCH 2/7] ppc64: EEH PCI address cache cleanups linas
2005-09-30 0:54 ` [PATCH 3/7] ppc64: EEH Add event/internal state statistics linas
2005-10-05 11:14 ` Paul Mackerras
2005-10-07 14:59 ` linas
2005-09-30 0:56 ` [PATCH 4/7] ppc64: EEH PCI slot error details abstraction linas
2005-09-30 0:58 ` [PATCH 5/7] ppc64: EEH handle empty PCI slot failure linas
2005-09-30 1:00 ` [PATCH 6/7] ppc64: EEH Avoid racing reports of errors linas
2005-10-05 11:23 ` Paul Mackerras
2005-10-07 15:23 ` linas
2005-09-30 1:02 ` [PATCH 7/7] ppc64: EEH Halt if bad drivers spin in error condition linas
2005-09-30 4:49 ` Doug Maxey
2005-09-30 14:58 ` linas
2005-09-30 22:29 ` [PATCH 0/7] ppc64: Assorted minor EEH cleanups linas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051007194644.GA29826@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox