From: Chris Wright <chrisw@osdl.org>
To: David Howells <dhowells@redhat.com>
Cc: Chris Wright <chrisw@osdl.org>,
torvalds@osdl.org, akpm@osdl.org, keyrings@linux-nfs.org,
linux-kernel@vger.kernel.org
Subject: Re: [Keyrings] [PATCH] Keys: Add LSM hooks for key management [try #2]
Date: Fri, 7 Oct 2005 16:35:47 -0700 [thread overview]
Message-ID: <20051007233547.GH5856@shell0.pdx.osdl.net> (raw)
In-Reply-To: <12605.1128728040@warthog.cambridge.redhat.com>
* David Howells (dhowells@redhat.com) wrote:
> Chris Wright <chrisw@osdl.org> wrote:
>
> > > +{
> > > + return -1;
> > > +}
> >
> > No solid reason on that one, might as well be 0 for consistency.
>
> Grrr! That needs to be zero otherwise it'll deny everything by default. I'd
> fallen over that one and fixed it, but I must've forgotten to rediff the patch
> before submitting it.
I thought that too at first, which is why I flagged it at first. But I
think it's actually not a real problem, because isn't that !CONFIG_KEYS?
So, I think it's just cosmetic.
next prev parent reply other threads:[~2005-10-07 23:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-07 14:07 [PATCH] Keys: Split key permissions checking into a .c file David Howells
2005-10-07 15:41 ` [PATCH] Keys: Possessor permissions should be additive David Howells
2005-10-07 15:57 ` [PATCH] Keys: Add LSM hooks for key management [try #2] David Howells
2005-10-07 16:08 ` [PATCH] Keys: Remove key duplication David Howells
2005-10-07 22:04 ` [Keyrings] [PATCH] Keys: Add LSM hooks for key management [try #2] Chris Wright
2005-10-07 23:34 ` David Howells
2005-10-07 23:35 ` Chris Wright [this message]
2005-10-07 23:38 ` David Howells
2005-10-07 23:45 ` David Howells
2005-10-07 23:46 ` Chris Wright
2005-10-07 23:46 ` Chris Wright
2005-10-08 6:51 ` [PATCH] Keys: Add LSM hooks for key management [try #3] Chris Wright
2005-11-01 14:16 ` [PATCH] Keys: Remove incorrect and obsolete '!' operators David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051007233547.GH5856@shell0.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox