From: Greg KH <greg@kroah.com>
To: Jiri Slaby <xslaby@fi.muni.cz>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH2 4/6] isicom: Pci probing added
Date: Mon, 10 Oct 2005 07:57:56 -0700 [thread overview]
Message-ID: <20051010145756.GA5530@kroah.com> (raw)
In-Reply-To: <20051009194221.38D3522AEAC@anxur.fi.muni.cz>
On Sun, Oct 09, 2005 at 09:42:22PM +0200, Jiri Slaby wrote:
> @@ -191,6 +198,7 @@ struct isi_board {
> u8 isa;
> spinlock_t card_lock; /* Card wide lock 11/5/00 -sameer */
> unsigned long flags;
> + struct device device;
What is this "struct device" used for? You do not need it.
> + printk(KERN_DEBUG "ISICOM: I/O Region 0x%x-0x%x is busy. "
> + "Card%d will be disabled.\n", board->base,
> + board->base + 15, index + 1);
For all of your printk() calls, please use dev_dbg() or dev_warn() or
the other dev_* calls please.
> +/* isi_card[idx].base = io[idx];
> + isi_card[idx].irq = irq[idx];
> + isi_card[idx].isa = YES;
> + FIXME: which device for request_firmware use? if you know, uncomment this and
> + delete printk and return
> + isi_card[idx].device = ???;
Register the firmware request for when you see the device that needs it,
in your probe function, not in your module init function.
Hope this helps,
greg k-h
next prev parent reply other threads:[~2005-10-10 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-09 19:39 [PATCH2 0/6] isicom char driver rewritten to 2.6 api Jiri Slaby
2005-10-09 19:41 ` [PATCH2 1/6] isicom: Whitespace cleanup Jiri Slaby
2005-10-09 19:42 ` [PATCH2 2/6] isicom: Type conversion and variables deletion Jiri Slaby
2005-10-10 17:27 ` Alan Cox
2005-10-09 19:42 ` [PATCH2 3/6] isicom: Other little changes Jiri Slaby
2005-10-09 19:42 ` [PATCH2 4/6] isicom: Pci probing added Jiri Slaby
2005-10-10 14:57 ` Greg KH [this message]
2005-10-09 19:42 ` [PATCH2 5/6] isicom: Firmware loading Jiri Slaby
2005-10-09 19:42 ` [PATCH2 6/6] isicom: More whitespaces and coding style Jiri Slaby
2005-10-10 4:05 ` Dmitry Torokhov
[not found] ` <4af2d03a0510100250r58fb24f1l1067bf5ad54bb659@mail.gmail.com>
2005-10-10 14:54 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051010145756.GA5530@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xslaby@fi.muni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox