From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Manu Abraham <manu@linuxtv.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PCI driver
Date: Mon, 10 Oct 2005 15:25:22 +0200 [thread overview]
Message-ID: <200510101525.27913@bilbo.math.uni-mannheim.de> (raw)
In-Reply-To: <434A6334.4090407@linuxtv.org>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
Am Montag, 10. Oktober 2005 14:48 schrieben Sie:
>Rolf Eike Beer wrote:
>>IIRC the call to pci_enable_device() must be the first thing you do. This
>> will do the things like assigning memory regions to the device and so on.
>
>I fixed this one
>
>>Returning 0 in error cases is just wrong. And you free the assignments even
>> in case of success AFAICS. Try the return I introduced above and see what
>> happens.
>
>I fixed this one too ..
>
>
>I have fixed most of the stuff, it is partly working, not ready yet as
>there are some more things to be added to ..
>I have attached what i was working on.
If the kmalloc() fails in mantis_pci_probe() you don't call
pci_disable_device(). And you should kzalloc() instead of kmalloc() and
memset().
It looks like you never use "__u16 vendor_id;" and "__u16 device_id;" in
struct mantis_pci.
Eike
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-10-10 13:20 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-14 9:34 PCI driver Manu Abraham
2005-09-14 10:03 ` Jiri Slaby
2005-09-14 10:02 ` Manu Abraham
2005-09-14 10:29 ` Jiri Slaby
2005-09-14 11:53 ` Manu Abraham
2005-09-14 12:22 ` Jiri Slaby
2005-09-14 12:28 ` Manu Abraham
2005-09-14 12:48 ` Manu Abraham
2005-09-14 16:16 ` Jiri Slaby
2005-09-14 17:09 ` Manu Abraham
2005-09-14 19:00 ` Jiri Slaby
2005-09-14 19:00 ` Manu Abraham
2005-09-14 19:16 ` Jiri Slaby
2005-09-14 19:20 ` Manu Abraham
2005-09-14 22:27 ` Manu Abraham
2005-09-15 6:43 ` Rolf Eike Beer
2005-09-15 7:45 ` Manu Abraham
2005-09-15 8:18 ` Rolf Eike Beer
2005-09-15 8:51 ` Manu Abraham
2005-09-15 9:48 ` Rolf Eike Beer
2005-09-15 14:38 ` Manu Abraham
2005-09-15 14:57 ` Rolf Eike Beer
2005-09-15 16:59 ` Manu Abraham
2005-09-15 18:29 ` Manu Abraham
2005-09-15 10:29 ` Ralph Metzler
2005-09-15 10:35 ` Manu Abraham
2005-09-15 11:42 ` Manu Abraham
2005-09-15 12:08 ` Antonino A. Daplas
2005-09-15 12:24 ` Rolf Eike Beer
2005-09-15 12:32 ` Manu Abraham
2005-09-15 12:08 ` Rolf Eike Beer
2005-10-10 12:02 ` Rolf Eike Beer
2005-10-10 12:48 ` Manu Abraham
2005-10-10 13:25 ` Rolf Eike Beer [this message]
2005-10-10 13:16 ` Manu Abraham
[not found] ` <3888a5cd0510100719r3fddc368oa01e07e2c42b71e@mail.gmail.com>
2005-10-10 15:00 ` Manu Abraham
[not found] ` <3888a5cd0510100846p7f2ff70cid69a1136b9256ab6@mail.gmail.com>
2005-10-10 17:08 ` Manu Abraham
[not found] ` <4af2d03a0510101101n54ab0b1cvae177c3c992bf9a9@mail.gmail.com>
2005-10-10 18:28 ` Manu Abraham
[not found] ` <3888a5cd0510100725k579809a9o374930df9988bfa3@mail.gmail.com>
2005-10-10 15:02 ` Manu Abraham
[not found] ` <4af2d03a0510100528y236a1246tfc56c08a78f072d5@mail.gmail.com>
2005-10-10 12:51 ` Manu Abraham
-- strict thread matches above, loose matches on Subject: below --
2010-08-28 12:17 pci driver Srinivas Mankan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510101525.27913@bilbo.math.uni-mannheim.de \
--to=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
--cc=manu@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox