public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [SCSI] qla2xxx: fix remote port timeout with qla2xxx driver
       [not found] <200510031643.j93GhgRY023585@hera.kernel.org>
@ 2005-10-10 17:01 ` Olaf Hering
  2005-10-11 23:31   ` Andrew Vasquez
  0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2005-10-10 17:01 UTC (permalink / raw)
  To: Linux Kernel Mailing List, Andrew Vasquez, James Bottomley; +Cc: linux-scsi

 On Mon, Oct 03, Linux Kernel Mailing List wrote:

> tree e50f57f9c85bacf3fc07359b1a339432dea31a7a
> parent 6f3a20242db2597312c50abc11f1e747c5d2326a
> author Andrew Vasquez <andrew.vasquez@qlogic.com> Wed, 21 Sep 2005 03:32:11 -0700
> committer James Bottomley <jejb@mulgrave.(none)> Sun, 25 Sep 2005 22:11:35 -0500
> 
> [SCSI] qla2xxx: fix remote port timeout with qla2xxx driver
> diff --git a/drivers/scsi/qla2xxx/qla_rscn.c b/drivers/scsi/qla2xxx/qla_rscn.c
> --- a/drivers/scsi/qla2xxx/qla_rscn.c
> +++ b/drivers/scsi/qla2xxx/qla_rscn.c
> @@ -330,6 +330,8 @@ qla2x00_update_login_fcport(scsi_qla_hos
>  	fcport->flags &= ~FCF_FAILOVER_NEEDED;
>  	fcport->iodesc_idx_sent = IODESC_INVALID_INDEX;
>  	atomic_set(&fcport->state, FCS_ONLINE);
> +	if (fcport->rport)
> +		fc_remote_port_unblock(fcport->rport);


This patch lacks an #include, probably scsi/scsi_transport_fc.h:

drivers/scsi/qla2xxx/qla_rscn.c:334: error: implicit declaration of function 'fc_remote_port_unblock'


-- 
short story of a lazy sysadmin:
 alias appserv=wotan

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [SCSI] qla2xxx: fix remote port timeout with qla2xxx driver
  2005-10-10 17:01 ` [SCSI] qla2xxx: fix remote port timeout with qla2xxx driver Olaf Hering
@ 2005-10-11 23:31   ` Andrew Vasquez
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Vasquez @ 2005-10-11 23:31 UTC (permalink / raw)
  To: Olaf Hering; +Cc: Linux Kernel Mailing List, James Bottomley, linux-scsi

On Mon, 10 Oct 2005, Olaf Hering wrote:

>  On Mon, Oct 03, Linux Kernel Mailing List wrote:
> 
> > tree e50f57f9c85bacf3fc07359b1a339432dea31a7a
> > parent 6f3a20242db2597312c50abc11f1e747c5d2326a
> > author Andrew Vasquez <andrew.vasquez@qlogic.com> Wed, 21 Sep 2005 03:32:11 -0700
> > committer James Bottomley <jejb@mulgrave.(none)> Sun, 25 Sep 2005 22:11:35 -0500
> > 
> > [SCSI] qla2xxx: fix remote port timeout with qla2xxx driver
> > diff --git a/drivers/scsi/qla2xxx/qla_rscn.c b/drivers/scsi/qla2xxx/qla_rscn.c
> > --- a/drivers/scsi/qla2xxx/qla_rscn.c
> > +++ b/drivers/scsi/qla2xxx/qla_rscn.c
> > @@ -330,6 +330,8 @@ qla2x00_update_login_fcport(scsi_qla_hos
> >  	fcport->flags &= ~FCF_FAILOVER_NEEDED;
> >  	fcport->iodesc_idx_sent = IODESC_INVALID_INDEX;
> >  	atomic_set(&fcport->state, FCS_ONLINE);
> > +	if (fcport->rport)
> > +		fc_remote_port_unblock(fcport->rport);
> 
> 
> This patch lacks an #include, probably scsi/scsi_transport_fc.h:
> 
> drivers/scsi/qla2xxx/qla_rscn.c:334: error: implicit declaration of function 'fc_remote_port_unblock'

Yes,  here's a one-liner to add the proper include.

---

diff --git a/drivers/scsi/qla2xxx/qla_rscn.c b/drivers/scsi/qla2xxx/qla_rscn.c
index 1eba988..11682a2 100644
--- a/drivers/scsi/qla2xxx/qla_rscn.c
+++ b/drivers/scsi/qla2xxx/qla_rscn.c
@@ -18,6 +18,8 @@
  */
 #include "qla_def.h"
 
+#include <scsi/scsi_transport_fc.h>
+
 /**
  * IO descriptor handle definitions.
  *

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-10-11 23:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <200510031643.j93GhgRY023585@hera.kernel.org>
2005-10-10 17:01 ` [SCSI] qla2xxx: fix remote port timeout with qla2xxx driver Olaf Hering
2005-10-11 23:31   ` Andrew Vasquez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox