Re: [PATCH 03/16] GFS: core fs

Jan Hudec
2005-10-11T12:15:48Z

[-- Attachment #1: Type: text/plain, Size: 823 bytes --]

On Mon, Oct 10, 2005 at 23:39:28 +0200, Pavel Machek wrote:
> Hi!
>
> > Signed-off-by: Ken Preslan <ken@preslan.org>
> > Signed-off-by: David Teigland <teigland@redhat.com>
>
> > + for (; blks; gfs2_replay_incr_blk(sdp, &start), blks--) {
>
> > + for (head = &ai->ai_ail1_list, tmp = head->prev, prev = tmp->prev;
> > + tmp != head;
> > + tmp = prev, prev = tmp->prev) {
>
>
> > + for (head = &ai->ai_ail1_list, tmp = head->prev, prev = tmp->prev;
> > + tmp != head;
> > + tmp = prev, prev = tmp->prev) {
>
>
> Can you get less creative in the for loops? [There are more examples
> at other patches, for (i=something; i--; ) was "nicest" example].

The later two are good examples of where list_for_each_safe is
appropriate.

--
Jan 'Bulb' Hudec <bulb@ucw.cz>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]