From: Al Viro <viro@ftp.linux.org.uk>
To: Greg KH <greg@kroah.com>
Cc: David Teigland <teigland@redhat.com>,
linux-kernel@vger.kernel.org, akpm@osdl.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 11/16] GFS: mount and tuning options
Date: Mon, 10 Oct 2005 22:30:26 +0100 [thread overview]
Message-ID: <20051010213025.GP7992@ftp.linux.org.uk> (raw)
In-Reply-To: <20051010211918.GA13920@kroah.com>
On Mon, Oct 10, 2005 at 02:19:18PM -0700, Greg KH wrote:
> > > > + rv += sprintf(buf + rv, "bsize %u\n", sdp->sd_sb.sb_bsize);
> > > > + rv += sprintf(buf + rv, "total %lld\n", sc.sc_total);
> > > > + rv += sprintf(buf + rv, "free %lld\n", sc.sc_free);
> > > > + rv += sprintf(buf + rv, "dinodes %lld\n", sc.sc_dinodes);
> > >
> > > No, 1 value per sysfs file please.
> >
> > I'm aware of that rule and have followed it everywhere else. This is a
> > special case where the one statfs produces three results.
>
> Then why not have 4 different files, for the result of the last "statfs"
> command?
More to the point, what the hell is that doing in sysfs in the first place?
next prev parent reply other threads:[~2005-10-10 21:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-10 17:10 [PATCH 11/16] GFS: mount and tuning options David Teigland
2005-10-10 21:01 ` Greg KH
2005-10-10 21:14 ` David Teigland
2005-10-10 21:19 ` Greg KH
2005-10-10 21:30 ` Al Viro [this message]
2005-10-10 22:22 ` David Teigland
2005-10-10 21:37 ` Al Viro
2005-10-11 21:38 ` David Teigland
2005-10-12 8:43 ` Jan Hudec
2005-10-12 16:12 ` David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051010213025.GP7992@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox