* [PATCH for 2.6.14] i386: Don't discard upper 32bits of HWCR on K8
@ 2005-10-10 23:28 Andi Kleen
0 siblings, 0 replies; only message in thread
From: Andi Kleen @ 2005-10-10 23:28 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel, discuss
Need to use long long, not long when RMWing a MSR. I think
it's harmless right now, but still should be better fixed
if AMD adds any bits in the upper 32bit of HWCR.
Bug was introduced with the TLB flush filter fix for i386
Signed-off-by: Andi Kleen <ak@suse.de>
Index: linux/arch/i386/kernel/cpu/amd.c
===================================================================
--- linux.orig/arch/i386/kernel/cpu/amd.c
+++ linux/arch/i386/kernel/cpu/amd.c
@@ -29,7 +29,7 @@ static void __init init_amd(struct cpuin
int r;
#ifdef CONFIG_SMP
- unsigned long value;
+ unsigned long long value;
/* Disable TLB flush filter by setting HWCR.FFDIS on K8
* bit 6 of msr C001_0015
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-10-10 23:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-10 23:28 [PATCH for 2.6.14] i386: Don't discard upper 32bits of HWCR on K8 Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox