From: Jan Hudec <bulb@ucw.cz>
To: David Teigland <teigland@redhat.com>,
linux-kernel@vger.kernel.org, akpm@osdl.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 03/16] GFS: core fs
Date: Tue, 11 Oct 2005 14:15:25 +0200 [thread overview]
Message-ID: <20051011121525.GC16249@djinn> (raw)
In-Reply-To: <20051010213928.GB2475@elf.ucw.cz>
[-- Attachment #1: Type: text/plain, Size: 823 bytes --]
On Mon, Oct 10, 2005 at 23:39:28 +0200, Pavel Machek wrote:
> Hi!
>
> > Signed-off-by: Ken Preslan <ken@preslan.org>
> > Signed-off-by: David Teigland <teigland@redhat.com>
>
> > + for (; blks; gfs2_replay_incr_blk(sdp, &start), blks--) {
>
> > + for (head = &ai->ai_ail1_list, tmp = head->prev, prev = tmp->prev;
> > + tmp != head;
> > + tmp = prev, prev = tmp->prev) {
>
>
> > + for (head = &ai->ai_ail1_list, tmp = head->prev, prev = tmp->prev;
> > + tmp != head;
> > + tmp = prev, prev = tmp->prev) {
>
>
> Can you get less creative in the for loops? [There are more examples
> at other patches, for (i=something; i--; ) was "nicest" example].
The later two are good examples of where list_for_each_safe is
appropriate.
--
Jan 'Bulb' Hudec <bulb@ucw.cz>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-10-11 12:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-10 17:10 [PATCH 03/16] GFS: core fs David Teigland
2005-10-10 21:39 ` Pavel Machek
2005-10-11 12:15 ` Jan Hudec [this message]
2005-10-11 14:55 ` David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051011121525.GC16249@djinn \
--to=bulb@ucw.cz \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox