Re: [PATCH 1/2] miss-sync changes on attributes (Re: [PATCH 2/2][FAT] miss-sync issues on sync mount (miss-sync on utime))

[Andrew Morton <akpm@osdl.org>]

"Machida, Hiroyuki" <machida@sm.sony.co.jp> wrote:
>
> This patch adds inode-sync after attribute changes, if needed.
> 
> * fs-sync-attr.patch for 2.6.13
> 
>  fs/fs-writeback.c      |   19 +++++++++++++++++++
>  fs/open.c              |   12 ++++++++++++
>  include/linux/fs.h     |    1 +
>  4 files changed, 32 insertions(+)
> 
> Signed-off-by: Hiroyuki Machida <machdia@sm.sony.co.jp>
> 
> --- linux-2.6.13/fs/fs-writeback.c	2005-08-29 08:41:01.000000000 +0900
> +++ linux-2.6.13-sync-attr/fs/fs-writeback.c	2005-09-29 12:56:21.052335295 +0900
> @@ -593,6 +593,25 @@ int sync_inode(struct inode *inode, stru
>  EXPORT_SYMBOL(sync_inode);
>  
>  /**
> + * sync_inode_wodata - sync(write and wait) inode to disk, without it's data.
> + * @inode: the inode to sync
> + *
> + * sync_inode_wodata() will write an inode  then wait.  It will also
> + * correctly update the inode on its superblock's dirty inode lists 
> + * and will update inode->i_state.
> + *
> + * The caller must have a ref on the inode.
> + */
> +int sync_inode_wodata(struct inode *inode)
> +{
> +	struct writeback_control wbc = {
> +		.sync_mode = WB_SYNC_ALL, /* wait */
> +		.nr_to_write = 0,/* no data to be written */
> +	};
> +	return sync_inode(inode, &wbc);
> +}
> +

I think this function duplicates write_inode_now()?