Re: [PATCH 11/16] GFS: mount and tuning options

Greg KH
2005-10-10T21:02:20Z

On Mon, Oct 10, 2005 at 12:10:52PM -0500, David Teigland wrote:
> +static ssize_t statfs_show(struct gfs2_sbd *sdp, char *buf)
> +{
> + struct gfs2_statfs_change sc;
> + int rv;
> +
> + if (gfs2_tune_get(sdp, gt_statfs_slow))
> + rv = gfs2_statfs_slow(sdp, &sc);
> + else
> + rv = gfs2_statfs_i(sdp, &sc);
> +
> + if (rv)
> + goto out;
> +
> + rv += sprintf(buf + rv, "bsize %u\n", sdp->sd_sb.sb_bsize);
> + rv += sprintf(buf + rv, "total %lld\n", sc.sc_total);
> + rv += sprintf(buf + rv, "free %lld\n", sc.sc_free);
> + rv += sprintf(buf + rv, "dinodes %lld\n", sc.sc_dinodes);

No, 1 value per sysfs file please.

> +/* FIXME: this should go under fs_subsys, /sys/fs/ */

Then put it there, there is a patch floating around that creates
/sys/fs/ but I haven't applied it as I need a user for it before I do.
Feel free to add that patch to your patch series.

thanks,

greg k-h