Re: [PATCH 11/16] GFS: mount and tuning options

Al Viro
2005-10-10T21:30:30Z

On Mon, Oct 10, 2005 at 02:19:18PM -0700, Greg KH wrote:
> > > > + rv += sprintf(buf + rv, "bsize %u\n", sdp->sd_sb.sb_bsize);
> > > > + rv += sprintf(buf + rv, "total %lld\n", sc.sc_total);
> > > > + rv += sprintf(buf + rv, "free %lld\n", sc.sc_free);
> > > > + rv += sprintf(buf + rv, "dinodes %lld\n", sc.sc_dinodes);
> > >
> > > No, 1 value per sysfs file please.
> >
> > I'm aware of that rule and have followed it everywhere else. This is a
> > special case where the one statfs produces three results.
>
> Then why not have 4 different files, for the result of the last "statfs"
> command?

More to the point, what the hell is that doing in sysfs in the first place?