Re: [PATCH 11/16] GFS: mount and tuning options

David Teigland
2005-10-10T21:14:39Z

On Mon, Oct 10, 2005 at 02:01:08PM -0700, Greg KH wrote:
> On Mon, Oct 10, 2005 at 12:10:52PM -0500, David Teigland wrote:
> > +static ssize_t statfs_show(struct gfs2_sbd *sdp, char *buf)
> > +{
> > + struct gfs2_statfs_change sc;
> > + int rv;
> > +
> > + if (gfs2_tune_get(sdp, gt_statfs_slow))
> > + rv = gfs2_statfs_slow(sdp, &sc);
> > + else
> > + rv = gfs2_statfs_i(sdp, &sc);
> > +
> > + if (rv)
> > + goto out;
> > +
> > + rv += sprintf(buf + rv, "bsize %u\n", sdp->sd_sb.sb_bsize);
> > + rv += sprintf(buf + rv, "total %lld\n", sc.sc_total);
> > + rv += sprintf(buf + rv, "free %lld\n", sc.sc_free);
> > + rv += sprintf(buf + rv, "dinodes %lld\n", sc.sc_dinodes);
>
> No, 1 value per sysfs file please.

I'm aware of that rule and have followed it everywhere else. This is a
special case where the one statfs produces three results.

> > +/* FIXME: this should go under fs_subsys, /sys/fs/ */
>
> Then put it there, there is a patch floating around that creates
> /sys/fs/ but I haven't applied it as I need a user for it before I do.
> Feel free to add that patch to your patch series.

OK, in the meantime, here it is:
http://marc.theaimsgroup.com/?l=linux-fsdevel&m=112548673418028&w=2

Dave