From: Jamie Lokier <jamie@shareable.org>
To: Janak Desai <janak@us.ibm.com>
Cc: chrisw@osdl.org, viro@ZenIV.linux.org.uk,
nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] New System call unshare (try 2)
Date: Thu, 13 Oct 2005 11:11:37 +0100 [thread overview]
Message-ID: <20051013101137.GA22049@mail.shareable.org> (raw)
In-Reply-To: <Pine.WNT.4.63.0510121201540.1316@IBM-AIP3070F3AM>
Janak Desai wrote:
> +
> +/*
> + * Performs sanity checks on the flags passed to the unshare system
> + * call.
> + */
> +static inline int check_unshare_flags(unsigned long unshare_flags)
After making the changes we talked about to the above function - it
would make sense for clone() to call it too. Have the tests in one
place, so both calls are consistent with each other, and will remain
so. The atomic_read() parts are dependent on the call being
unshare(), but the bit tests should be identical I think.
-- Jamie
prev parent reply other threads:[~2005-10-13 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-12 16:07 [PATCH] New System call unshare (try 2) Janak Desai
2005-10-12 17:19 ` Jamie Lokier
2005-10-12 18:17 ` Janak Desai
2005-10-12 23:54 ` Jamie Lokier
2005-10-13 10:13 ` Chris Wright
2005-10-13 13:27 ` Janak Desai
2005-10-13 9:58 ` Chris Wright
2005-10-13 10:11 ` Jamie Lokier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051013101137.GA22049@mail.shareable.org \
--to=jamie@shareable.org \
--cc=akpm@osdl.org \
--cc=chrisw@osdl.org \
--cc=janak@us.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox