From: Jens Axboe <axboe@suse.de>
To: "Ananiev, Leonid I" <leonid.i.ananiev@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] indirect function calls elimination in IO eliminate
Date: Thu, 13 Oct 2005 20:05:45 +0200 [thread overview]
Message-ID: <20051013180545.GJ6603@suse.de> (raw)
In-Reply-To: <6694B22B6436BC43B429958787E454988AA6F7@mssmsx402nb>
On Thu, Oct 13 2005, Ananiev, Leonid I wrote:
>
>
> Fully modular io schedulers and enables online switching between
> them was introduced in Linux 2.6.10 but as a result percentage
> of CPU using by kernel was increased and performance degradation
> is marked on Itanium. A cause of degradation is in more steps
> for indirect IO scheduler type specific function calls.
>
> The patch eliminates 45 indirect function calls in 16 elevator
> functions. Sysbench fileio benchmark throughput was increased at 2%
> for noop elevator after patching.
I don't really see the patch doing what you describe - the indirect
function calls are the same, what you did was inline the actual elevator
structure in the queue again. This breaks reference counting of said
structure, so it's not really something that can be applied. I'm
guessing what you saw was a decrease in cache misses, maybe we can do
something about that instead.
Can you say more about the throughput increase? From what to what and on
what hardware?
Oh, and your patch is totally screwed, check your mail setup.
--
Jens Axboe
next parent reply other threads:[~2005-10-13 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6694B22B6436BC43B429958787E454988AA6F7@mssmsx402nb>
2005-10-13 18:05 ` Jens Axboe [this message]
2005-10-13 16:07 [PATCH 1/1] indirect function calls elimination in IO eliminate Ananiev, Leonid I
2005-10-13 17:55 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051013180545.GJ6603@suse.de \
--to=axboe@suse.de \
--cc=leonid.i.ananiev@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox