public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Christian <evil@g-house.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Dallas's 1-wire bus compile error (again)
Date: Thu, 13 Oct 2005 22:33:54 +0400	[thread overview]
Message-ID: <20051013183353.GA32530@2ka.mipt.ru> (raw)
In-Reply-To: <434EA63F.10306@g-house.de>

On Thu, Oct 13, 2005 at 08:23:59PM +0200, Christian (evil@g-house.de) wrote:
> hi,
> 
> playing around with "make randconfig" (don't ask :)), i noticed the
> driver for the "Dallas's 1-wire bus" does not compile when CONFIG_NET is 
> disabled.
> 
> this was discussed earlier in
> 
>   http://www.ussg.iu.edu/hypermail/linux/kernel/0408.1/1764.html
> 
> but the discussion ended up in arguing about using "depends" over 
> "select" and the actual fix was forgotten i think.

Hmm... Could you please provide error log.
Networking is only used for netlink notifications which are disabled 
if CONFIG_NET is not set, you can find empty declarations in
w1_netlink.c

drivers/w1/Makefile has following for that case:
ifneq ($(CONFIG_NET), y)
EXTRA_CFLAGS    += -DNETLINK_DISABLED
endif


> Signed-off-by: Christian Kujau <evil@g-house.de>
> 
> thanks,
> Christian.
> -- 
> BOFH excuse #446:
> 
> Mailer-daemon is busy burning your message in hell.

> --- linux-2.6/drivers/w1/Kconfig.orig	2005-10-13 20:09:44.813986698 +0200
> +++ linux-2.6/drivers/w1/Kconfig	2005-10-13 20:10:21.613460153 +0200
> @@ -2,6 +2,7 @@ menu "Dallas's 1-wire bus"
>  
>  config W1
>  	tristate "Dallas's 1-wire support"
> +	depends on NET
>  	---help---
>  	  Dallas's 1-wire bus is usefull to connect slow 1-pin devices
>  	  such as iButtons and thermal sensors.


-- 
	Evgeniy Polyakov

  reply	other threads:[~2005-10-13 18:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-13 18:23 [PATCH] Dallas's 1-wire bus compile error (again) Christian
2005-10-13 18:33 ` Evgeniy Polyakov [this message]
2005-10-13 19:20   ` Christian
2005-10-13 19:47     ` Evgeniy Polyakov
2005-10-13 20:14       ` Christian
  -- strict thread matches above, loose matches on Subject: below --
2005-10-13 18:27 Christian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051013183353.GA32530@2ka.mipt.ru \
    --to=johnpol@2ka.mipt.ru \
    --cc=evil@g-house.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox