From: Jens Axboe <axboe@suse.de>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] remove gendisk->stamp_idle field
Date: Thu, 13 Oct 2005 21:16:43 +0200 [thread overview]
Message-ID: <20051013191642.GN6603@suse.de> (raw)
In-Reply-To: <200510131913.j9DJDNg07632@unix-os.sc.intel.com>
On Thu, Oct 13 2005, Chen, Kenneth W wrote:
> struct gendisk has these two fields: stamp, stamp_idle. Update to
> stamp_idle is always in sync with stamp and they are always the same.
> Therefore, it does not add any value in having two fields tracking
> same timestamp. Suggest to remove it.
>
> Also, we should only update gendisk stats with non-zero value.
> Advantage is that we don't have to needlessly calculate memory address,
> and then add zero to the content.
Acked-by: Jens Axboe <axboe@suse.de>
Added to the upstream Linus branch of the block git tree.
--
Jens Axboe
prev parent reply other threads:[~2005-10-13 19:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-13 19:13 [patch] remove gendisk->stamp_idle field Chen, Kenneth W
2005-10-13 19:16 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051013191642.GN6603@suse.de \
--to=axboe@suse.de \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox