public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Parag Warudkar <kernel-stuff@comcast.net>
Cc: Christian Krause <chkr@plauener.de>, linux-kernel@vger.kernel.org
Subject: Re: bug in handling of highspeed usb HID devices
Date: Thu, 13 Oct 2005 20:31:19 -0700	[thread overview]
Message-ID: <20051014033118.GA7956@kroah.com> (raw)
In-Reply-To: <101420050210.18923.434F13890004C6F8000049EB220076106400009A9B9CD3040A029D0A05@comcast.net>

On Fri, Oct 14, 2005 at 02:10:17AM +0000, Parag Warudkar wrote:
> > 
> > Also, what device needs this patch?  Is it a device that I can buy
> > today?
> > 
> > thanks,
> > 
> > greg k-h
> 
> The patch is for hid-core.c - I don't think it is device specific -
> original problem should affect all High Speed USB HID devices. 

I realize that, my point is are there any such devices out in the wild
that people can buy and use?  I do not know of any.

> To summarize -
> 
> Current code just looks plain wrong since the same logic is repeated
> twice - endpoint->bInterval is operated upon twice if the device is
> HIGH SPEED one.

I agree.  That's wrong and should be fixed.  A patch would be nice...

thanks,

greg k-h

  reply	other threads:[~2005-10-14  3:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-14  2:10 bug in handling of highspeed usb HID devices Parag Warudkar
2005-10-14  3:31 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-10-14 15:21 kernel-stuff
2005-10-13 20:11 Parag Warudkar
2005-10-13 20:25 ` Andrew Morton
2005-10-12 23:32 Parag Warudkar
2005-10-13 18:05 ` Christian Krause
2005-10-12 21:10 kernel-stuff
2005-10-12 21:42 ` Christian Krause
2005-10-12 19:55 Christian Krause
2005-10-13 22:48 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051014033118.GA7956@kroah.com \
    --to=greg@kroah.com \
    --cc=chkr@plauener.de \
    --cc=kernel-stuff@comcast.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox