From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750777AbVJNSEQ (ORCPT ); Fri, 14 Oct 2005 14:04:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750801AbVJNSEQ (ORCPT ); Fri, 14 Oct 2005 14:04:16 -0400 Received: from mail.suse.de ([195.135.220.2]:59058 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1750777AbVJNSEP (ORCPT ); Fri, 14 Oct 2005 14:04:15 -0400 Date: Fri, 14 Oct 2005 20:04:14 +0200 From: Andi Kleen To: Chuck Ebbert <76306.1226@compuserve.com> Cc: linux-kernel , Andi Kleen , Andrew Morton , Linus Torvalds , Ingo Molnar Subject: Re: [patch 2.6.14-rc4] i386: spinlock optimization Message-ID: <20051014180414.GD3502@verdi.suse.de> References: <200510141350_MC3-1-ACA0-C8C9@compuserve.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510141350_MC3-1-ACA0-C8C9@compuserve.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 14, 2005 at 01:47:09PM -0400, Chuck Ebbert wrote: > Attempt to acquire spinlock sooner after spinning and then noticing > it has become available. Also adds a slight delay before testing the > spinlock again when it's not available, reducing bus traffic. I doubt your change adds any noticeable delay on a aggressive OOO CPU, which are pretty much all modern x86s. It's probably a nop. -Andi