Re: [PATCH] Re: bug in handling of highspeed usb HID devices

Greg KH
2005-10-14T23:42:55Z

On Fri, Oct 14, 2005 at 07:57:45PM +0200, Christian Krause wrote:
> --- linux-2.6.13.4/drivers/usb/input/hid-core.c.old 2005-10-12 21:29:29.000000000 +0200
> +++ linux-2.6.13.4/drivers/usb/input/hid-core.c 2005-10-12 21:31:02.000000000 +0200
> @@ -1667,11 +1667,6 @@ static struct hid_device *usb_hid_config
> if ((endpoint->bmAttributes & 3) != 3) /* Not an interrupt endpoint */
> continue;
>
> - /* handle potential highspeed HID correctly */
> - interval = endpoint->bInterval;
> - if (dev->speed == USB_SPEED_HIGH)
> - interval = 1 << (interval - 1);
> -

Did you try this patch out? It is wrong. Please look at the compiler
warning that this change generates and redo the patch.

thanks,

greg k-h