From: Al Viro <viro@ftp.linux.org.uk>
To: "David S. Miller" <davem@davemloft.net>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] highest_possible_processor_id() has to be a macro
Date: Sun, 16 Oct 2005 08:46:26 +0100 [thread overview]
Message-ID: <20051016074626.GC7992@ftp.linux.org.uk> (raw)
In-Reply-To: <20051016.001649.94729039.davem@davemloft.net>
On Sun, Oct 16, 2005 at 12:16:49AM -0700, David S. Miller wrote:
> From: Al Viro <viro@ftp.linux.org.uk>
> Date: Sun, 16 Oct 2005 00:51:12 +0100
>
> > ... otherwise, things like alpha and sparc64 break and break
> > badly. They define cpu_possible_map to something else in smp.h
> > *AFTER* having included cpumask.h.
>
> So ugly...
>
> But, it's the best fix for now.
>
> Longer term we might want to make an asm/cpumask.h that can
> help allow the platforms to cleanly say "well, mask X is
> equivalent to Y, so only instantiate X and define Y to X"
Indeed, but playing with moving stuff from smp.h is definitely post-2.6.14
fodder...
prev parent reply other threads:[~2005-10-16 7:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-15 23:51 [PATCH] highest_possible_processor_id() has to be a macro Al Viro
2005-10-16 7:16 ` David S. Miller
2005-10-16 7:43 ` Herbert Xu
2005-10-16 7:46 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051016074626.GC7992@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox