From: emard@softhome.net
To: linux-kernel@vger.kernel.org
Subject: Re: uinput crash and NO FIX YET
Date: Sun, 16 Oct 2005 23:12:52 +0200 [thread overview]
Message-ID: <20051016211252.GA21557@tink> (raw)
In-Reply-To: <20051016115139.GB2084@tink>
Seems the crash is coming from bad locking
I have located exact place where the problem is manifested and
did this patch:
--- drivers/input/misc/uinput.c.orig 2005-10-15 10:09:38.000000000 +0200
+++ drivers/input/misc/uinput.c 2005-10-16 22:19:20.000000000 +0200
@@ -93,7 +93,8 @@ static void uinput_request_done(struct u
complete(&request->done);
/* Mark slot as available */
- udev->requests[request->id] = NULL;
+ if(request->id >= 0 && request->id < UINPUT_NUM_REQUESTS)
+ udev->requests[request->id] = NULL;
wake_up_interruptible(&udev->requests_waitq);
}
This checks wether request id has some sane value.
This way I have avoided crashes but now I'm running
of request[ ] slots, sometimes they tend to leak and
when all the slots are exhausted no more effects can
be accepted.
next prev parent reply other threads:[~2005-10-16 21:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-15 21:29 uinput crash and fix emard
2005-10-15 22:01 ` Mattia Dongili
2005-10-15 22:48 ` Mattia Dongili
2005-10-15 22:51 ` emard
2005-10-16 11:51 ` uinput crash and NO FIX YET emard
2005-10-16 21:12 ` emard [this message]
2005-10-16 22:06 ` [PATCH] uinput crash maybe this is the FIX emard
2005-10-17 5:55 ` Dmitry Torokhov
2005-10-17 7:16 ` emard
2005-10-17 21:28 ` Let this uinput patch go to 2.6.14 emard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051016211252.GA21557@tink \
--to=emard@softhome.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox