From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932280AbVJQNmd (ORCPT ); Mon, 17 Oct 2005 09:42:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751341AbVJQNmd (ORCPT ); Mon, 17 Oct 2005 09:42:33 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:35219 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1751328AbVJQNmc (ORCPT ); Mon, 17 Oct 2005 09:42:32 -0400 Date: Mon, 17 Oct 2005 14:42:28 +0100 From: Christoph Hellwig To: "Kolli, Neela Syam" Cc: Russell King , Linux Kernel List , Andrew Morton , Greg KH , linux-scsi@vger.kernel.org Subject: Re: [PATCH 2/2] Convert megaraid to use pci_driver shutdown metho d Message-ID: <20051017134228.GA31938@infradead.org> Mail-Followup-To: Christoph Hellwig , "Kolli, Neela Syam" , Russell King , Linux Kernel List , Andrew Morton , Greg KH , linux-scsi@vger.kernel.org References: <0E3FA95632D6D047BA649F95DAB60E5707232141@exa-atlanta> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E5707232141@exa-atlanta> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 17, 2005 at 09:26:12AM -0400, Kolli, Neela Syam wrote: > Patch looks good. Thanks for the patch. another 2.6.14 candidate, without it we'd easily get corruption on shutdown when the root filesystem is on megaraid. > From: Russell King [mailto:rmk+lkml@arm.linux.org.uk] > Sent: Sunday, October 16, 2005 4:33 PM > To: Linux Kernel List; Andrew Morton; Greg KH; Neela.Kolli@engenio.com > Subject: Re: [PATCH 2/2] Convert megaraid to use pci_driver shutdown method > > Convert megaraid to use pci_driver's shutdown method rather than > the generic device_driver shutdown method. > > Signed-off-by: Russell King > > diff --git a/drivers/scsi/megaraid/megaraid_mbox.c > b/drivers/scsi/megaraid/megaraid_mbox.c > --- a/drivers/scsi/megaraid/megaraid_mbox.c > +++ b/drivers/scsi/megaraid/megaraid_mbox.c > @@ -76,7 +76,7 @@ static void megaraid_exit(void); > > static int megaraid_probe_one(struct pci_dev*, const struct pci_device_id > *); > static void megaraid_detach_one(struct pci_dev *); > -static void megaraid_mbox_shutdown(struct device *); > +static void megaraid_mbox_shutdown(struct pci_dev *); > > static int megaraid_io_attach(adapter_t *); > static void megaraid_io_detach(adapter_t *); > @@ -369,9 +369,7 @@ static struct pci_driver megaraid_pci_dr > .id_table = pci_id_table_g, > .probe = megaraid_probe_one, > .remove = __devexit_p(megaraid_detach_one), > - .driver = { > - .shutdown = megaraid_mbox_shutdown, > - } > + .shutdown = megaraid_mbox_shutdown, > }; > > > @@ -673,9 +671,9 @@ megaraid_detach_one(struct pci_dev *pdev > * Shutdown notification, perform flush cache > */ > static void > -megaraid_mbox_shutdown(struct device *device) > +megaraid_mbox_shutdown(struct pci_dev *pdev) > { > - adapter_t *adapter = > pci_get_drvdata(to_pci_dev(device)); > + adapter_t *adapter = pci_get_drvdata(pdev); > static int counter; > > if (!adapter) { >